1837333 - Do not attempt to clear the WebRTC stats history

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P1)

Description

[Nico Grunbaum [:ng, @chew:mozilla.org]]

We shouldn't clear the stats history on the child process.

Comment 1

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1837333 - webrtc stats history should be cleared on parent process only;r?pehrsons

The stats history only lives on the parent process. Clearing the logs from about:webrtc causes a (non-release) assertion. This was missed in testing. I will look into changing that in a follow up Bug 1837335.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1830790

Comment 3

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Comment on attachment 9338002 [details]
Bug 1837333 - webrtc stats history should be cleared on parent process only;r?pehrsons

Beta/Release Uplift Approval Request

• User impact if declined: Opening about:webrtc in beta will cause a crash
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This simple patch only restricts a code path to the parent process.
• String changes made/needed:
• Is Android affected?: No

Comment 4

[Donal Meehan [:dmeehan]]

:ng is there anything blocking landing this? Then relman can review the uplift request

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5c0e709eb52
webrtc stats history should be cleared on parent process only;r=pehrsons

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/f5c0e709eb52

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9338002 [details]
Bug 1837333 - webrtc stats history should be cleared on parent process only;r?pehrsons

Approved for 115.0b6.

Comment 8

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/258820d8a8db