1830859 - Implement "browsingContext.reload" command

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, enhancement, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This command will provide the capability to reload the current page.

Wdspec tests for this command are already getting added via https://github.com/web-platform-tests/wpt/pull/39739.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] from comment #0)

Wdspec tests for this command are already getting added via https://github.com/web-platform-tests/wpt/pull/39739.

Actually there will be several PRs for tests. With that one the basic validation tests will be added. As such we probably want to wait until https://github.com/GoogleChromeLabs/chromium-bidi/pull/654 has been fixed.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We are waiting for the functionality tests to be added via https://github.com/web-platform-tests/wpt/pull/40134.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I'll have a look if we can get this quickly implemented. As such I'll create a new bug for handling the optional ignoreCache boolean parameter which requires a specific test, and isn't covered yet by the already existent wdspec tests.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I noticed that the WebDriver BiDi specification is wrong. At the moment no NavigationResult is getting returned, which is needed by clients to actually listen for certain events. I filed https://github.com/w3c/webdriver-bidi/issues/527 to get this fixed. As such I'm going to also let Firefox return an empty result for now, and file a new bug to get the NavigationResult added once the specification has been fixed.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1830859 - [webdriver-bidi] Implement "browsingContext.reload" command.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1830859 - [wdspec] Strenghten WebDriver BiDi reload tests.

Depends on D187445

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0212e4b4c8ae
[webdriver-bidi] Implement "browsingContext.reload" command. r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/3ccfd029bb7a
[wdspec] Strenghten WebDriver BiDi reload tests. r=webdriver-reviewers,Sasha

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41841 for changes under testing/web-platform/tests

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0212e4b4c8ae
https://hg.mozilla.org/mozilla-central/rev/3ccfd029bb7a

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Web Platform Test Sync Bot (Matrix: #interop:mozilla.org) from comment #8)

Created web-platform-tests PR
https://github.com/web-platform-tests/wpt/pull/41841 for changes under
testing/web-platform/tests

The upstream PR has been merged now.