1851583 - "browsingContext.reload" command has to return a "NavigateResult"

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, enhancement, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

As per the BiDi specification there is no NavigationResult returned at the moment, which is needed by clients to actually listen for certain events. I filed https://github.com/w3c/webdriver-bidi/issues/527 to get this fixed.

Once the specification has been updated we have to return a NavigationResult response.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

The WebDriver BiDi issue has been fixed. So we can get this fixed once bug 1830859 landed.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Actually the BiDi issue got reopened and there is a discussion about the navigation id. As such lets wait until we have a clear path forward.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

When working on this bug it would be good to actually address the review comment from https://phabricator.services.mozilla.com/D187445#6204269 which raced with the landing request and couldn't applied anymore.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

For the upstream issue we decided to file a follow-up issue for the special case, and as such closed it. That means we can get started to implement the NavigateResult. I can have a look at this later today.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Attachment: Bug 1851583 - [webdriver-bidi] Update "browsingContext.reload" command to return a "NavigateResult".

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1] (away from Feb 12th - Feb 22nd)]

Attachment: Bug 1851583 - [wdspec] Update tests for browsingContext.reload to expect a "NavigateResult".

Depends on D187754

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00e0560c4f72
[webdriver-bidi] Update "browsingContext.reload" command to return a "NavigateResult". r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/371f21acf806
[wdspec] Update tests for browsingContext.reload to expect a "NavigateResult". r=webdriver-reviewers,jdescottes

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41911 for changes under testing/web-platform/tests

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by thiagowfx

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/00e0560c4f72
https://hg.mozilla.org/mozilla-central/rev/371f21acf806