1830962 - Update wasm2c to disable Wasm exception handling code from runtime

Status: RESOLVED FIXED

(Core :: Security: RLBox, enhancement, P3)

Description

[Shravan Narayan]

Wasm2c's runtime currently includes support for Wasm exception handling -- a feature which is not used by RLBox's library sandboxing, but has a large security surface. While this part of the runtime should theoretically be dead code, this update allows us to guarantee this part of the runtime is not included at all, and is a better choice.

Comment 1

[Shravan Narayan]

Attachment: Bug 1830962: Update wasm2c to disable Wasm exception handling code from runtime r=glandium

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6fceae307b7c
Update wasm2c to disable Wasm exception handling code from runtime r=glandium

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out changeset 6fceae307b7c (Bug 1830962) for causing build bustages in rlbox.wasm.h

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=S_EWQ7Q_SRSYVhx5CU_FNg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=6fceae307b7c1654b41252ae67cf7691a0e16a39

Log: https://treeherder.mozilla.org/logviewer?job_id=414454220&repo=autoland&lineNumber=11034

Backout: https://hg.mozilla.org/integration/autoland/rev/788de0f66cdf7ae9b7b6f8caf5d0d6117223df4c

Comment 4

[Shravan Narayan]

I have pushed an updated patch

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b29a8a264671
Update wasm2c to disable Wasm exception handling code from runtime r=glandium

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/b29a8a264671