1830979 - Reduce number of rows rendered in scroll event

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, enhancement)

Description

[Sean Burke [:leftmostcat]]

At present, each scroll causes the full tolerance buffer to be added to the DOM, including data fetch, synchronously. This makes long scrolls extremely expensive.

Comment 1

[MM]

You're aware of Ben's "prototype" which doesn't create new rows but uses and repopulates the existing ones?

http://benbucksch.github.io/trex/fastlist-test.html - This works best in Firefox.
From https://mail.mozilla.org/pipermail/tb-planning/2017-March/005322.html

Comment 2

[Sean Burke [:leftmostcat]]

(In reply to MM from comment #1)

You're aware of Ben's "prototype" which doesn't create new rows but uses and repopulates the existing ones?

I had not been, thank you! That was one of the techniques I tried during prototyping, though I hit some bugs in the process. The first stage of this is just making sure we're not filling in rows which aren't visible and may be thrown away on the next frame, as that currently requires an XPCOM call. The next stage, however, is exactly that: reusing a single set of rows to avoid adding/removing components from the DOM altogether. Those links will likely help a lot.

Comment 3

[Sean Burke [:leftmostcat]]

Attachment: Bug 1830979 - Break out and standardize tree element visibility calculations. r=#thunderbird-reviewers

Comment 4

[Sean Burke [:leftmostcat]]

Attachment: Bug 1830979 - Only fill tolerance buffer during idle ticks. r=#thunderbird-reviewers

Depends on D177213

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f09945e842c2
Break out and standardize tree element visibility calculations. r=darktrojan
https://hg.mozilla.org/comm-central/rev/cec216f5abd4
Only fill tolerance buffer during idle ticks. r=darktrojan

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9331716 [details]
Bug 1830979 - Only fill tolerance buffer during idle ticks. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9331715 [details]
Bug 1830979 - Break out and standardize tree element visibility calculations. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 114.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/c4daa20ef270
https://hg.mozilla.org/releases/comm-beta/rev/55a6465b947b