1831229 - Include open tabs in recently-closed tabs list from closed windows

Status: NEW

(Firefox :: Session Restore, enhancement, P3)

Description

[Sam Foster [:sfoster] (he/him)]

From the user's point of view, a "recently-closed tab" is a tab that was open and now is not. It shouldn't matter if that tab was closed in a window that itself was recently closed. Or was open in window that is now closed - these are all recently-closed tabs.

This shouldn't change session restore behaviour, just the history menus and firefox-view's recently-closed tabs list.

Comment 1

[Sarah Clements [:sclements]]

Sam will address preserving closed tabs from windows that are closed in his patch for bug 1819675. This bug should address adding tabs that were open in any windows that are closed in a session (not the last window) to the recently closed tabs list. See the solution for bug 1820660, which is handling a similar situation as it pertains to the last closed window.

Comment 2

[Sam Foster [:sfoster] (he/him)]

(In reply to Sarah Clements [:sclements] from comment #1)

Sam will address preserving closed tabs from windows that are closed in his patch for bug 1819675.

I've opened bug 1833522 for this, as bug 1819675 already has a lot going on.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1831229 - Share some of sessionstore's test helpers for use in recently-closed tab tests. r?sclements!

• Move closeTab and openAndCloseTab to the helpers module and replace a couple of uses
• Move waitForBrowserState/promiseBrowserState and replace a couple of uses

Comment 4

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 9351927 [details]
Bug 1831229 - Share some of sessionstore's test helpers for use in recently-closed tab tests. r?sclements!

Wrong patch on wrong bug