1833522 - Recently-closed tabs lists should include closed tabs from recently closed windows

Status: RESOLVED FIXED

(Firefox :: Session Restore, enhancement, P1)

Description

[Sam Foster [:sfoster] (he/him)]

When we are building the list of recently closed tabs for firefox view and the history menus, it should include the closed tab lists from recently closed windows. These are not the tabs which were open at the time the window was closed - which is bug 1831229

Comment 1

[Sam Foster [:sfoster] (he/him)]

:robwu, I'd like to preemptively de-couple this bug from any discussion of extension API changes by again avoiding any change to what the session API does and returns in the patch I'm developing for this bug. When that lands, it will introduce a gap between the behavior in the browser UI - in terms of what the recently-closed tabs menus show vs what sessions.getRecentlyClosed returns. If we break that out into its own bug we can discuss if or when we want to close that gap to enable extension developers to also retrieve and restore closed tabs from closed windows. Does that sounds like a reasonable plan? We'll still need to watch out for unintentional regressions from the patch I land here of course.

Comment 2

[Rob Wu [:robwu]]

(In reply to Sam Foster [:sfoster] (he/him) from comment #1)

:robwu, I'd like to preemptively de-couple this bug from any discussion of extension API changes by again avoiding any change to what the session API does and returns in the patch I'm developing for this bug. When that lands, it will introduce a gap between the behavior in the browser UI - in terms of what the recently-closed tabs menus show vs what sessions.getRecentlyClosed returns. If we break that out into its own bug we can discuss if or when we want to close that gap to enable extension developers to also retrieve and restore closed tabs from closed windows. Does that sounds like a reasonable plan? We'll still need to watch out for unintentional regressions from the patch I land here of course.

That sounds like a very reasonable path forwards. The API does not need to change; extensions can already query all recently closed tabs (including inside closed windows) through the API. If there is ever a desire to change the API, make sure to update bug 1836877 (for dev outreach).

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1833522 - Add closed tabs from closed windows to the history:recently-closed tab menus. r?dao!

Depends on D185108

Comment 4

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1833522 - Share some of sessionstore's test helpers for use in recently-closed tab tests. r?sclements!

• Move closeTab and openAndCloseTab to the helpers module and replace a couple of uses
• Move waitForBrowserState/promiseBrowserState and replace a couple of uses

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb1598dc258f
Share some of sessionstore's test helpers for use in recently-closed tab tests. r=sclements,fxview-reviewers,sessionstore-reviewers
https://hg.mozilla.org/integration/autoland/rev/feb42cf3b6e1
Add closed tabs from closed windows to the history:recently-closed tab menus. r=dao,extension-reviewers,sessionstore-reviewers,sclements,robwu,Standard8,fxview-reviewers

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/fb1598dc258f
https://hg.mozilla.org/mozilla-central/rev/feb42cf3b6e1