1831302 - Debugger source code has custom stylelint setup in mozilla-central which seems not-in-use / broken (as actually running stylelint produces errors)

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[:Gijs (he/him)]

In bug 1508369 I'm trying to add stylelint support to the tree.

I'm seeing errors in devtools/client/debugger/ files. There are custom stylelint configurations there, which are the rules producing errors:

devtools/client/debugger/src/components/PrimaryPanes/Outline.css
  5:1  error  Expected no more than 1 empty line (max-empty-lines)  max-empty-lines (stylelint)

devtools/client/debugger/src/components/shared/AccessibleImage.css
  153:58  error  Expected a trailing semicolon (declaration-block-trailing-semicolon)  declaration-block-trailing-semicolon (stylelint)

devtools/client/debugger/src/utils/editor/source-editor.css
  108:16  error  Expected "#b9f" to be "#bb99ff" (color-hex-length)                                      color-hex-length (stylelint)
  108:32  error  Expected newline after "," in a multi-line list (value-list-comma-newline-after)        value-list-comma-newline-after (stylelint)
  108:34  error  Expected "#b9f" to be "#bb99ff" (color-hex-length)                                      color-hex-length (stylelint)
  108:52  error  Expected newline after "," in a multi-line list (value-list-comma-newline-after)        value-list-comma-newline-after (stylelint)
  108:54  error  Expected "#b9f" to be "#bb99ff" (color-hex-length)                                      color-hex-length (stylelint)
  109:5   error  Expected "#b9f" to be "#bb99ff" (color-hex-length)                                      color-hex-length (stylelint)
  121:10  error  Expected "#555" to be "#555555" (color-hex-length)                                      color-hex-length (stylelint)
  205:28  error  Expected double colon pseudo-element notation (selector-pseudo-element-colon-notation)  selector-pseudo-element-colon-notation (stylelint)
  220:36  error  Expected double colon pseudo-element notation (selector-pseudo-element-colon-notation)  selector-pseudo-element-colon-notation (stylelint)
  224:35  error  Expected double colon pseudo-element notation (selector-pseudo-element-colon-notation)  selector-pseudo-element-colon-notation (stylelint)
  228:31  error  Expected double colon pseudo-element notation (selector-pseudo-element-colon-notation)  selector-pseudo-element-colon-notation (stylelint)
  232:34  error  Expected double colon pseudo-element notation (selector-pseudo-element-colon-notation)  selector-pseudo-element-colon-notation (stylelint)
  236:35  error  Expected double colon pseudo-element notation (selector-pseudo-element-colon-notation)  selector-pseudo-element-colon-notation (stylelint)
  240:35  error  Expected double colon pseudo-element notation (selector-pseudo-element-colon-notation)  selector-pseudo-element-colon-notation (stylelint)
  244:33  error  Expected double colon pseudo-element notation (selector-pseudo-element-colon-notation)  selector-pseudo-element-colon-notation (stylelint)
  249:10  error  Expected "#999" to be "#999999" (color-hex-length)                                      color-hex-length (stylelint)

Plus about 100 errors for devtools/client/debugger/test/mochitest/examples/ember/quickstart/dist/assets/test-support.css which I've elided for brevity.

I don't really know what the status of this infra is, but for now I'll probably ignore all the files that produce errors in the global stylelint ignore file I'm adding. If someone else has context on this and/or knows what a better final state would look like, that'd be great!

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1831302 - [devtools] remove unused debugger .stylelintrc and .stylelintignore. r=Gijs.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8ce718ab7c7
[devtools] remove unused debugger .stylelintrc and .stylelintignore. r=Gijs,devtools-reviewers,ochameau.

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b8ce718ab7c7