1831329 - Reddit Video playback causes Firefox to crash on Windows 10

Status: VERIFIED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Simona Badau, Desktop QA]

Attachment: Screen recording of the issue

Found in

• Nightly 114.0a1

Affected versions

• Nightly 114
• Firefox 113 beta
• Firefox 112.0.2

Tested platforms

• Affected platforms: Windows 10

Steps to reproduce

1. Open a new tab and go to this Reddit video
2. Click on the Play button.

Expected result

• The video should play properly until it ends.

Actual result

• The video starts and after a few seconds, the whole window turns white for a short period, the UI is restored but the video is stuck to a certain frame even though the audio still runs in the background. This crash can be found in about:crashes.
  https://crash-stats.mozilla.org/report/index/8fab0b0f-157e-4f98-886d-439c80230504
• If I close Firefox and open it again, I either get the Close Firefox dialog or another crash like:
  https://crash-stats.mozilla.org/report/index/c4524408-48cf-4194-a41a-fe7000230504

Regression range
I could not reproduce this issue on Firefox 102.10.0esr, but I could reproduce it on Firefox 112.0.2 and on Firefox 113 Beta.
Looked for a regression window and got the white flicker until:

• Last good revision: 88a5bf648f2f45eec3572e678d74434206a66159
• First bad revision: 6c4c49f17ed0a862d289609ff45b3ae66454a402
• Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=88a5bf648f2f45eec3572e678d74434206a66159&tochange=6c4c49f17ed0a862d289609ff45b3ae66454a402
• Potentially regressed by: Bug 1766282

Additional notes

• The issue is not reproducible on all the Reddit videos, but another one that shows the same behavior is this one.
• Tried to reproduce the crashes on 2 other Windows 10 machines but I couldn't.

Comment 1

[Simona Badau, Desktop QA]

Attachment: aboutsupport.txt

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:sotaro, since you are the author of the regressor, bug 1766282, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: about_support.txt

I could not reproduce the problem with similar GPU. Then it might be cased by an old driver.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1766282

Comment 5

[Sotaro Ikeda [:sotaro]]

0x1912 is in [DeviceFamily::IntelSkylake]https://searchfox.org/mozilla-central/rev/ee6ab6eb2d222e0004604de62206baa67cac33af/widget/GfxDriverInfo.cpp#315).

GPU #1
Active: Yes
Description: Intel(R) HD Graphics 530
Vendor ID: 0x8086
Device ID: 0x1912
Driver Version: 20.19.15.4390
Driver Date: 2-18-2016

And DeviceFamily::IntelSkylake is already blocked with FEATURE_HW_DECODED_VIDEO_ZERO_COPY

• https://searchfox.org/mozilla-central/rev/ee6ab6eb2d222e0004604de62206baa67cac33af/widget/windows/GfxInfo.cpp#1768
• https://searchfox.org/mozilla-central/rev/ee6ab6eb2d222e0004604de62206baa67cac33af/widget/windows/GfxInfo.cpp#1775

Comment 6

[Sotaro Ikeda [:sotaro]]

It seems necessary to block FEATURE_HW_DECODED_VIDEO_ZERO_COPY. It might be necessary to block also FEATURE_REUSE_DECODER_DEVICE.

Comment 7

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1831329 - Block FEATURE_HW_DECODED_VIDEO_ZERO_COPY with Driver Version: 20.19.15.4390

Comment 8

[Sotaro Ikeda [:sotaro]]

Simona Badau, can you check if D177864 blocks FEATURE_HW_DECODED_VIDEO_ZERO_COPY? And can you also check if D177864 addresses the problem for you?

Blocking of FEATURE_HW_DECODED_VIDEO_ZERO_COPY could be checked at about:support

The following build could be used for checking.

• https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/DYtsqwokR7-_GM1g-np9Pw/runs/0/artifacts/public%2Fbuild%2Ftarget.zip
• https://treeherder.mozilla.org/jobs?repo=try&revision=cf50dd034a6fd2cf305391003b0c439e5181f625

Comment 9

[Simona Badau, Desktop QA]

Attachment: FEATURE_HW_DECODED_VIDEO_ZERO_COPY - blocked screenshot

(In reply to Sotaro Ikeda [:sotaro] from comment #8)

Simona Badau, can you check if D177864 blocks FEATURE_HW_DECODED_VIDEO_ZERO_COPY? And can you also check if D177864 addresses the problem for you?

Blocking of FEATURE_HW_DECODED_VIDEO_ZERO_COPY could be checked at about:support

The following build could be used for checking.

• https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/DYtsqwokR7-_GM1g-np9Pw/runs/0/artifacts/public%2Fbuild%2Ftarget.zip
• https://treeherder.mozilla.org/jobs?repo=try&revision=cf50dd034a6fd2cf305391003b0c439e5181f625

Yes, the HW_DECODED_VIDEO_ZERO_COPY is blocked in about:support and I am no longer able to reproduce the crashes on the above build.

Comment 10

[Sotaro Ikeda [:sotaro]]

Great! Thank you.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b0a89a9fae8
Block FEATURE_HW_DECODED_VIDEO_ZERO_COPY with Driver Version: 20.19.15.4390 r=gfx-reviewers,ErichDonGubler

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9b0a89a9fae8

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:sotaro, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox114 to wontfix.

For more information, please visit BugBot documentation.

Comment 14

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9333258 [details]
Bug 1831329 - Block FEATURE_HW_DECODED_VIDEO_ZERO_COPY with Driver Version: 20.19.15.4390

Beta/Release Uplift Approval Request

• User impact if declined: GPU process crash happens during video playback with Intel HD Graphics 530 of Driver Version: 20.19.15.4390.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change simply extends an existing block list.
• String changes made/needed: none
• Is Android affected?: No

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Should we take this on Release for next week's planned dot release also?

Comment 16

[Sotaro Ikeda [:sotaro]]

:jrmuizel, do we need to take the fix to Release?

Comment 17

[Pascal Chevrel:pascalc]

Comment on attachment 9333258 [details]
Bug 1831329 - Block FEATURE_HW_DECODED_VIDEO_ZERO_COPY with Driver Version: 20.19.15.4390

Approved for 114.0b5, thanks

Comment 18

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/e0851e3e0927

Comment 19

[Jeff Muizelaar [:jrmuizel]]

I think we should take it to release.

Comment 20

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9333258 [details]
Bug 1831329 - Block FEATURE_HW_DECODED_VIDEO_ZERO_COPY with Driver Version: 20.19.15.4390

Beta/Release Uplift Approval Request

• User impact if declined: GPU process crash happens during video playback with Intel HD Graphics 530 of Driver Version: 20.19.15.4390.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The change simply extends an existing block list.
• String changes made/needed: none
• Is Android affected?: No

Comment 21

[Simona Badau, Desktop QA]

Verified as fixed on the latest Nightly 115.0a1 and Firefox 114.0b5 - no more crashes on Windows 10 when using the scenario from the Description.

However, I found a scenario in the builds with this fix: Nightly 115.0a1 and Firefox 114.0b5 (Firefox 113.0.1 is not affected) where Firefox becomes unresponsive if multiple Reddit videos are played simultaneously. Logged Bug 1833809 to cover this.

Comment 22

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9333258 [details]
Bug 1831329 - Block FEATURE_HW_DECODED_VIDEO_ZERO_COPY with Driver Version: 20.19.15.4390

Approved for 113.0.2.

Comment 23

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/ec26c420eea4

Comment 24

[Ryan VanderMeulen [:RyanVM]]

Added to the 113.0.2 release notes:

Fixed a video playback crash on some Windows systems with Intel graphics

Comment 25

[Simona Badau, Desktop QA]

Verified as fixed using the latest Firefox 13.0.2 on Windows 10 x64 with Intel HD Graphics 530 of Driver Version: 20.19.15.4390.