Closed Bug 1831329 Opened 1 year ago Closed 11 months ago

Reddit Video playback causes Firefox to crash on Windows 10

Categories

(Core :: Audio/Video: Playback, defect)

Product:
Core
Component:
Audio/Video: Playback
Platform:
Desktop
Windows 10
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
115 Branch
Tracking Flags:
Tracking Status
relnote-firefox --- 113+
firefox-esr102 --- disabled
firefox112 --- wontfix
firefox113 --- verified
firefox114 --- verified
firefox115 --- verified

People

(Reporter: sbadau, Assigned: sotaro)

References

(Regression)

Details

(Keywords: crash, regression)

Crash Data

Attachments

(5 files)

Screen recording of the issue
8.57 MB, image/gif
Details
aboutsupport.txt
38.57 KB, text/plain
Details
about_support.txt
39.94 KB, text/plain
Details
Bug 1831329 - Block FEATURE_HW_DECODED_VIDEO_ZERO_COPY with Driver Version: 20.19.15.4390
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
RyanVM
: approval-mozilla-release+
Details | Review
FEATURE_HW_DECODED_VIDEO_ZERO_COPY - blocked screenshot
4.56 KB, image/png
Details

Found in

  • Nightly 114.0a1

Affected versions

  • Nightly 114
  • Firefox 113 beta
  • Firefox 112.0.2

Tested platforms

  • Affected platforms: Windows 10

Steps to reproduce

  1. Open a new tab and go to this Reddit video
  2. Click on the Play button.

Expected result

  • The video should play properly until it ends.

Actual result

Regression range
I could not reproduce this issue on Firefox 102.10.0esr, but I could reproduce it on Firefox 112.0.2 and on Firefox 113 Beta.
Looked for a regression window and got the white flicker until:

Additional notes

  • The issue is not reproducible on all the Reddit videos, but another one that shows the same behavior is this one.
  • Tried to reproduce the crashes on 2 other Windows 10 machines but I couldn't.
Attached file aboutsupport.txt —

:sotaro, since you are the author of the regressor, bug 1766282, could you take a look?

For more information, please visit BugBot documentation.

Flags: needinfo?(sotaro.ikeda.g)
Attached file about_support.txt —

I could not reproduce the problem with similar GPU. Then it might be cased by an old driver.

See Also: → 1831696
Assignee: nobody → sotaro.ikeda.g
Flags: needinfo?(sotaro.ikeda.g)

Set release status flags based on info from the regressing bug 1766282

status-firefox115: --- → affected

0x1912 is in [DeviceFamily::IntelSkylake]https://searchfox.org/mozilla-central/rev/ee6ab6eb2d222e0004604de62206baa67cac33af/widget/GfxDriverInfo.cpp#315).

GPU #1
Active: Yes
Description: Intel(R) HD Graphics 530
Vendor ID: 0x8086
Device ID: 0x1912
Driver Version: 20.19.15.4390
Driver Date: 2-18-2016

And DeviceFamily::IntelSkylake is already blocked with FEATURE_HW_DECODED_VIDEO_ZERO_COPY

It seems necessary to block FEATURE_HW_DECODED_VIDEO_ZERO_COPY. It might be necessary to block also FEATURE_REUSE_DECODER_DEVICE.

Simona Badau, can you check if D177864 blocks FEATURE_HW_DECODED_VIDEO_ZERO_COPY? And can you also check if D177864 addresses the problem for you?

Blocking of FEATURE_HW_DECODED_VIDEO_ZERO_COPY could be checked at about:support

The following build could be used for checking.

Flags: needinfo?(sbadau)

(In reply to Sotaro Ikeda [:sotaro] from comment #8)

Simona Badau, can you check if D177864 blocks FEATURE_HW_DECODED_VIDEO_ZERO_COPY? And can you also check if D177864 addresses the problem for you?

Blocking of FEATURE_HW_DECODED_VIDEO_ZERO_COPY could be checked at about:support

The following build could be used for checking.

Yes, the HW_DECODED_VIDEO_ZERO_COPY is blocked in about:support and I am no longer able to reproduce the crashes on the above build.

Flags: needinfo?(sbadau)

Great! Thank you.

Pushed by sikeda.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9b0a89a9fae8
Block FEATURE_HW_DECODED_VIDEO_ZERO_COPY with Driver Version: 20.19.15.4390 r=gfx-reviewers,ErichDonGubler

https://hg.mozilla.org/mozilla-central/rev/9b0a89a9fae8

Status: NEW → RESOLVED
Closed: 11 months ago
status-firefox115: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 115 Branch

The patch landed in nightly and beta is affected.
:sotaro, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox114 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(sotaro.ikeda.g)

Comment on attachment 9333258 [details]
Bug 1831329 - Block FEATURE_HW_DECODED_VIDEO_ZERO_COPY with Driver Version: 20.19.15.4390

Beta/Release Uplift Approval Request

  • User impact if declined: GPU process crash happens during video playback with Intel HD Graphics 530 of Driver Version: 20.19.15.4390.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The change simply extends an existing block list.
  • String changes made/needed: none
  • Is Android affected?: No
Flags: needinfo?(sotaro.ikeda.g)
Attachment #9333258 - Flags: approval-mozilla-beta?

Should we take this on Release for next week's planned dot release also?

Flags: needinfo?(sotaro.ikeda.g)

:jrmuizel, do we need to take the fix to Release?

Flags: needinfo?(jmuizelaar)

Comment on attachment 9333258 [details]
Bug 1831329 - Block FEATURE_HW_DECODED_VIDEO_ZERO_COPY with Driver Version: 20.19.15.4390

Approved for 114.0b5, thanks

Attachment #9333258 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I think we should take it to release.

Flags: needinfo?(jmuizelaar)

Comment on attachment 9333258 [details]
Bug 1831329 - Block FEATURE_HW_DECODED_VIDEO_ZERO_COPY with Driver Version: 20.19.15.4390

Beta/Release Uplift Approval Request

  • User impact if declined: GPU process crash happens during video playback with Intel HD Graphics 530 of Driver Version: 20.19.15.4390.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The change simply extends an existing block list.
  • String changes made/needed: none
  • Is Android affected?: No
Flags: needinfo?(sotaro.ikeda.g)
Attachment #9333258 - Flags: approval-mozilla-release?
Regressions: 1833809

Verified as fixed on the latest Nightly 115.0a1 and Firefox 114.0b5 - no more crashes on Windows 10 when using the scenario from the Description.

However, I found a scenario in the builds with this fix: Nightly 115.0a1 and Firefox 114.0b5 (Firefox 113.0.1 is not affected) where Firefox becomes unresponsive if multiple Reddit videos are played simultaneously. Logged Bug 1833809 to cover this.

status-firefox114: fixed → verified
status-firefox115: fixed → verified
No longer regressions: 1833809
See Also: → 1833809
Regressions: 1833809

Comment on attachment 9333258 [details]
Bug 1831329 - Block FEATURE_HW_DECODED_VIDEO_ZERO_COPY with Driver Version: 20.19.15.4390

Approved for 113.0.2.

Attachment #9333258 - Flags: approval-mozilla-release? → approval-mozilla-release+

Added to the 113.0.2 release notes:

Fixed a video playback crash on some Windows systems with Intel graphics

relnote-firefox: --- → 113+

Verified as fixed using the latest Firefox 13.0.2 on Windows 10 x64 with Intel HD Graphics 530 of Driver Version: 20.19.15.4390.

Status: RESOLVED → VERIFIED
status-firefox113: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: