1831514 - Test manifest parser should complain about assignment conditions

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[:Gijs (he/him)]

There are at least 4 tests that are disabled everywhere because we assign rather than condition tests, just for the os information bit:

https://searchfox.org/mozilla-central/search?q=os+%3D+&path=.ini&case=false&regexp=false

Another 2 that do this with os_version:

https://searchfox.org/mozilla-central/search?q=os_version+%3D+&path=.ini&case=false&regexp=false

and probably more that do the same kind of thing with test information bits whose names I can't think of right now.

The ini file parser should fail to parse this so people don't add bogus test conditions.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1831514 - make assignments in .ini test manifests break parsing, r?jmaher

Comment 2

[:Gijs (he/him)]

Attachment: Bug 1831514 - add test for manifest parser complaining about broken conditions, r?jmaher

Depends on D177244

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/76177ecd9fe6
make assignments in .ini test manifests break parsing, r=jmaher
https://hg.mozilla.org/integration/autoland/rev/7a353e9b5023
add test for manifest parser complaining about broken conditions, r=jmaher

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/76177ecd9fe6
https://hg.mozilla.org/mozilla-central/rev/7a353e9b5023