1831535 - Bookmarks/history sidebar scrollbar does not update to window being vertically resized.

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Kestrel]

Attachment: Sidebar scrollbar comparison between good (left) and bad (right)

STR:

1. Open Bookmarks/History sidebar (Ctrl+B or Ctrl+H).
2. Resize the window vertically.

Expected:
Vertical scrollbar in sidebar appears/disappears and adjusts immediately to new height.

Actual:
Vertical scrollbar does not reflect the actual sidebar height until the width is changed.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f65fcbd54512e1a4e8d5827ff539294f38392c68&tochange=4afe60aa1ef491059f5ce749ab17427058027622

Regressed by Bug 1824957.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1824957, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1831535 - Fix nsTreeBodyFrame invalidation on height changes. r=#layout

The previous code ran right before setting mRect so it triggered a
reflow callback / scrollbar update.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1824957

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6185766e19d
Fix nsTreeBodyFrame invalidation on height changes. r=layout-reviewers,dlrobertson

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/a6185766e19d

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox114 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9331815 [details]
Bug 1831535 - Fix nsTreeBodyFrame invalidation on height changes. r=#layout

Beta/Release Uplift Approval Request

• User impact if declined: Comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively simple fix, worst case we invalidate a bit more.
• String changes made/needed: none
• Is Android affected?: No

Comment 8

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-05-05 Nightly build on Windows 10.
Verified as fixed on Nightly 115.0a1(build ID: 20230515215623) on Windows 10, Ubuntu 22, macOS 12.
Bookmark sidebar scrollbar now adjusts itself to the browser window’s height.

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9331815 [details]
Bug 1831535 - Fix nsTreeBodyFrame invalidation on height changes. r=#layout

Approved for 114 beta 5, thanks.

Comment 10

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/ad0aba175279

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Did you want to nominate this for Release approval as well?

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9331815 [details]
Bug 1831535 - Fix nsTreeBodyFrame invalidation on height changes. r=#layout

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively simple patch.
• String changes made/needed: none
• Is Android affected?: No

Comment 13

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-05-05 Nightly build on Windows 10.
Verified as fixed on Firefox 114.0b5(build ID: 20230516224108) on Windows 10, macOS 12, Ubuntu 22.
Bookmark sidebar scrollbar now adjusts itself to the browser window’s height.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9331815 [details]
Bug 1831535 - Fix nsTreeBodyFrame invalidation on height changes. r=#layout

Approved for 113.0.2.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/5c57e8a1527b

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Added to the 113.0.2 release notes:

Fixed a bug which would cause the bookmarks and history sidebars to not properly react to the browser window being vertically resized

Comment 17

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-05-05 Nightly build on Windows 10.
Verified as fixed on Firefox 103.0.2(build ID: 20230522134052) on Windows 10, macOS 12, Ubuntu 22.
Bookmark sidebar scrollbar now adjusts itself to the browser window’s height.