1824957 - Stop using XUL layout for nsTreeBodyFrame.

Status: RESOLVED FIXED

(Core :: XUL, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1824957 - Use SimpleXULLeafFrame for treebody. r=jwatt

Surprisingly straight-forward:

Use SimpleXULLeafFrame, and override GetIntrinsicBSize to implement the rows
attribute.

Use DidReflow to manage the reflow callback which is equivalent to what the old
code did.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1824957 - Remove a bunch of now completely dead XUL layout code. r=#layout

And some related tests.

A bunch of -moz-box* properties are web exposed, so I'll file a
follow-up for hiding them.

Depends on D173818

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30b054c6db5a
Use SimpleXULLeafFrame for treebody. r=jwatt

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1824957 - Null-check tree selection in preferences search. r=Gijs

The selection getter is nullable. Not having this check causes
browser_experimental_features_filter.js to fail due to the thrown
exception.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/103bb482b0bd
Null-check tree selection in preferences search. r=Gijs

Comment 6

[Norisz Fay [:noriszfay]]

Backed out for causing reftest failures on treechildren-padding-percent-1.xhtml

Backout link

Push with failures

Failure log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4afe60aa1ef4
Use SimpleXULLeafFrame for treebody. r=jwatt

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/103bb482b0bd

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/4afe60aa1ef4

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e21add6bf2c
Remove a bunch of now completely dead XUL layout code. r=layout-reviewers,desktop-theme-reviewers,devtools-reviewers,dao,TYLin

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0e21add6bf2c