1831540 - On the network section, walked through requests, while the "Request" tap open and JSON mode active

Status: RESOLVED DUPLICATE of bug 1849946

(DevTools :: Netmonitor, defect, P3)

Description

[aydinnecefov]

Attachment: firefox_bug_1.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/113.0

Steps to reproduce:

1. Sent two different requests to server, one PUT and the other POST, while the Network tab is open
2. Selected the request then opened "Request" tab to see payloads.
3. Started changing between payloads of requests sent to the server 3 times

Actual results:

Network tab crashed

Expected results:

Switch from payload of one request to other.

Comment 1

[Julian Descottes [:jdescottes]]

Thanks for the report,

The screenshot is missing the actual error, which should be displayed above the stacktraces, could you share that information if you can easily reproduce?

Some additional questions:

Started changing between payloads of requests sent to the server 3 times

To be sure: this means you are selecting one request then switching to the other request, then back to the previous one etc...?

JSON mode

Can you share an example of the data you see displayed in the Request tab?

Thanks

Comment 2

[Julian Descottes [:jdescottes]]

Nicolas managed to reproduce and will share Steps to reproduce with an example.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

of course now I can't reproduce anymore.
Here's a demo page with an STR on it https://ffx-devtools-netmonitor-crash-request-panel-json-payload.glitch.me/
This is what I was doing when I manage to reproduce

Comment 4

[aydinnecefov]

Sorry for late response.

Started changing between payloads of requests sent to the server 3 times

To be sure: this means you are selecting one request then switching to the other request, then back to the previous one etc...?

Yes, that was the case

JSON mode

Can you share an example of the data you see displayed in the Request tab?

It was just a usual JSON payload. The error occurred when I switched back and forth between two requests with raw mode on. Unfortunately, I cannot reproduce the exact situation. I was investigating a bug in our own software when this happened, so I don't know if it was related to the exact error code, payload, or something else.

Comment 5

[Julian Descottes [:jdescottes]]

Thanks for the update,

Just in case if you manage to reproduce the bug again, can you copy the actual error message?

Edit: also additional question, did you notice that there was a button to file a bug directly when there is an error in DevTools. If yes it would be super interesting for us to know why you didn't use it, and took a screenshot instead. We would like to make the feature easier to use, so the feedback would be useful.

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Reproduced again
From this page, in the split console, I fired a few requests with fetch("/", { method: "POST", body: JSON.stringify(Array.from({length: 10000}, (_, i) => (Math.random())))})

Then in netmonitor try to select those requests and other ones

Here's the error stack I got:

TypeError: can't convert nextProps.member[prop] to primitive type
    in TreeRow
    in tbody
    in table
    in TreeView
    in div
    in div
    in PropertiesView
    in VisibilityHandler
    in Unknown
    in Connect(Component)
    in div
    in RequestPanel
    in VisibilityHandler
    in Unknown
    in Connect(Component)
    in div
    in Panel
    in div
    in div
    in div
    in Tabs
    in Sidebar
    in div
    in Tabbar
    in TabboxPanel
    in div
    in NetworkDetailsBar
    in VisibilityHandler
    in Unknown
    in Connect(Component)
    in div
    in div
    in SplitBox
    in div
    in MonitorPanel
    in VisibilityHandler
    in Unknown
    in Connect(Component)
    in div
    in DropHarHandler
    in AppErrorBoundary
    in div
    in App
    in VisibilityHandler
    in Unknown
    in Connect(Component)
    in Provider

Stacktrace:
shouldComponentUpdate@resource://devtools/client/shared/components/tree/TreeRow.js:124:13
checkShouldComponentUpdate@resource://devtools/client/shared/vendor/react-dom.js:8233:33
updateClassInstance@resource://devtools/client/shared/vendor/react-dom.js:8517:62
updateClassComponent@resource://devtools/client/shared/vendor/react-dom.js:10599:20
beginWork@resource://devtools/client/shared/vendor/react-dom.js:11419:16
performUnitOfWork@resource://devtools/client/shared/vendor/react-dom.js:14702:12
workLoop@resource://devtools/client/shared/vendor/react-dom.js:14720:24
renderRoot@resource://devtools/client/shared/vendor/react-dom.js:14803:15
performWorkOnRoot@resource://devtools/client/shared/vendor/react-dom.js:15655:17
performWork@resource://devtools/client/shared/vendor/react-dom.js:15567:24
performSyncWork@resource://devtools/client/shared/vendor/react-dom.js:15541:14
interactiveUpdates$1@resource://devtools/client/shared/vendor/react-dom.js:15808:7
interactiveUpdates@resource://devtools/client/shared/vendor/react-dom.js:1901:10
dispatchInteractiveEvent@resource://devtools/client/shared/vendor/react-dom.js:4328:21

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:Honza, since the bug has recent activity, could you have a look please?

For more information, please visit BugBot documentation.

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Bug 1849946 mentioned the exact same issue and was fixed, so let's dupe this