Closed Bug 1849946 Opened 1 years ago Closed 1 year ago

TypeError: can't convert nextProps.member[prop] to primitive type

Categories

(DevTools :: Netmonitor, defect, P2)

Firefox 116
defect

Tracking

(firefox119 fixed)

RESOLVED FIXED
119 Branch
Tracking Status
firefox119 --- fixed

People

(Reporter: dztangyinhao, Assigned: bomsy)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/116.0

Steps to reproduce:

Clicking on the details of several post requests on the network panel and switching back and forth between several requests, an error occurred while switching to one request。

Actual results:

【React Component Stack】

componentStack

in TreeRow

in tbody

in table

in TreeView

in div

in div

in PropertiesView

in VisibilityHandler

in Unknown

in Connect(Component)

in div

in RequestPanel

in VisibilityHandler

in Unknown

in Connect(Component)

in div

in Panel

in div

in div

in div

in Tabs

in Sidebar

in div

in Tabbar

in TabboxPanel

in div

in NetworkDetailsBar

in VisibilityHandler

in Unknown

in Connect(Component)

in div

in div

in SplitBox

in div

in MonitorPanel

in VisibilityHandler

in Unknown

in Connect(Component)

in div

in DropHarHandler

in AppErrorBoundary

in div

in App

in VisibilityHandler

in Unknown

in Connect(Component)

in Provider

【Stacktrace】

shouldComponentUpdate@resource://devtools/client/shared/components/tree/TreeRow.js:124:13

checkShouldComponentUpdate@resource://devtools/client/shared/vendor/react-dom.js:8233:33

updateClassInstance@resource://devtools/client/shared/vendor/react-dom.js:8517:62

updateClassComponent@resource://devtools/client/shared/vendor/react-dom.js:10599:20

beginWork@resource://devtools/client/shared/vendor/react-dom.js:11419:16

performUnitOfWork@resource://devtools/client/shared/vendor/react-dom.js:14702:12

workLoop@resource://devtools/client/shared/vendor/react-dom.js:14720:24

renderRoot@resource://devtools/client/shared/vendor/react-dom.js:14803:15

performWorkOnRoot@resource://devtools/client/shared/vendor/react-dom.js:15655:17

performWork@resource://devtools/client/shared/vendor/react-dom.js:15567:24

performSyncWork@resource://devtools/client/shared/vendor/react-dom.js:15541:14

interactiveUpdates$1@resource://devtools/client/shared/vendor/react-dom.js:15808:7

interactiveUpdates@resource://devtools/client/shared/vendor/react-dom.js:1901:10

dispatchInteractiveEvent@resource://devtools/client/shared/vendor/react-dom.js:4328:21

Expected results:

no error

Thanks for reporting.

I can't reproduce.

But this likley happens because we are not doing a strict inequality check here https://searchfox.org/mozilla-central/rev/e7b8d13b7513b6fbd97d69e882d7faeed05309d0/devtools/client/shared/components/tree/TreeRow.js#124, this causes to likely try to cast and compare the types of the member properties. This feels like it might be difficult reproduce consistently. In any case we should ideally switch to do a strict inequality check.

TYH,
Where you able to reproduce this consistently, if so please can you provide STR ... if not, that's ok. Just need to clarify

Flags: needinfo?(dztangyinhao)
Assignee: nobody → hmanilla
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Severity: -- → S3
Priority: -- → P2
Blocks: 1484005
Pushed by hmanilla@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a66eb43b8b7b [devtools] Switch to do strict inequality check r=devtools-reviewers,ochameau
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
Duplicate of this bug: 1854597
Duplicate of this bug: 1859177
Duplicate of this bug: 1860194
Duplicate of this bug: 1860151
See Also: → 1864905
Duplicate of this bug: 1831540
Flags: needinfo?(dztangyinhao)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: