1831754 - Disabled menuitems shouldn't get hover treatment

Status: VERIFIED FIXED

(Toolkit :: Themes, defect)

Description

[Dão Gottwald [:dao]]

Attachment: Screenshot from 2023-05-06 22-27-32.png

As of bug 1828413 menuitems change their background on hover even when they're disabled. They shouldn't do that.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1831754 - Disabled menuitems shouldn't get hover treatment. r=emilio

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e5e0e87258a
Disabled menuitems shouldn't get hover treatment. r=emilio

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/7e5e0e87258a

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 9332032 [details]
Bug 1831754 - Disabled menuitems shouldn't get hover treatment. r=emilio

Beta/Release Uplift Approval Request

• User impact if declined: see comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: It's easy to test this with the tab context menu when there's only one tab in the window, or with the page context menu when there's no back/forward history.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): trivial CSS-only fix
• String changes made/needed:
• Is Android affected?: No

Comment 5

[Pascal Chevrel:pascalc]

Comment on attachment 9332032 [details]
Bug 1831754 - Disabled menuitems shouldn't get hover treatment. r=emilio

Approved for 114 beta 2, thanks.

Comment 6

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/2fea1242ca23

Comment 7

[Giorgia Nichita, Release Desktop QA]

Attachment: disabled menuitems hover effect.gif

Comment 8

[Giorgia Nichita, Release Desktop QA]

Reproduced this issue on an affected Nightly build from 2023-05-06 on Ubuntu 22.04.
Verified as fixed on Firefox 114.0b2 (20230509180058) and Firefox 115.0a1 (20230511094802) on Ubuntu 22.04 and macOS 10.15.

This issue is reproducible on Windows 10 x64 on all versions (115.0a1, 114.0b2, 113.0, 102.11esr). A lighter grey is applied on hover for the disabled menu items. Is this expected for Windows or should I reopen the bug? I attached a gif with the behavior on Win 10.

Comment 9

[Dão Gottwald [:dao]]

(In reply to Giorgia Nichita, Release Desktop QA from comment #8)

This issue is reproducible on Windows 10 x64 on all versions (115.0a1, 114.0b2, 113.0, 102.11esr). A lighter grey is applied on hover for the disabled menu items. Is this expected for Windows or should I reopen the bug? I attached a gif with the behavior on Win 10.

This seems to be expected on Windows:

https://searchfox.org/mozilla-central/rev/1f0f0e29a7bcb6d6dc82fe628861bccc2066a98e/toolkit/themes/windows/global/menu.css#56-61

https://searchfox.org/mozilla-central/rev/1f0f0e29a7bcb6d6dc82fe628861bccc2066a98e/widget/windows/nsLookAndFeel.cpp#295-299

Comment 10

[Giorgia Nichita, Release Desktop QA]

Thank you Dão!
Based on Comment 9, I will mark this issue as verified.