1831760 - Use a native context menu for the result menu on Mac

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

Attachment: Native vs. non-native on Mac

The urlbar result menu is not an OS-native menu. On Mac, the selection and submenu arrow don't look right. It's especially noticeable because of the arrow.

nsXULPopupManager::ShowPopup() doesn't check to see if the popup should be a native popup. However, nsXULPopupManager::ShowPopupAtScreen() does, so if we change resultMenu.openPopup() to resultMenu.openPopupAtScreen() and tell it to use a context menu, we get a nice native menu. That behavior was added in bug 1702041.

I asked mstange about it, and he said:

I didn’t convert the other APIs because I ran out of time
See https://bugzilla.mozilla.org/show_bug.cgi?id=1710459
If openPopup is easy to native-ify, that would be great! I’ve just never looked into it.

The ideal fix would be to modify ShowPopup(), but in the short term (114 -- we're shipping the weather suggestion in 114) I think we should use openPopupAtScreen() instead.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1831760 - Use a native popup menu for positioned popups on Mac.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48223b575381
Use a native popup menu for positioned popups on Mac. r=dao,mstange

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/48223b575381

Comment 4

[Drew Willcoxon :adw]

For QA verification, the urlbar result menu should look like the "Native" image (the one on the right) in comment 0. There shouldn't be any weirdness or jank or anything when using it, it should just behave like a native Mac menu, and it should open under the Feedback button or reasonably close to it when the window is near the edge of the screen.

Comment 5

[Carmen Fat [:cfat] - Ecosystem QA]

We have verified this task on the latest Firefox Nightly 115.0a1 (Build ID: 20230518213154) on macOS 12.6.1.

• The urlbar result menu looks like the "Native" one from comment 0. We also did not experience any visual issues while interacting with it.