1861950 - Use standard anchored popup for the result menu on Mac

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/autoland/rev/d28557bfe634 and bug 1861671 should remove the need for this workaround: https://searchfox.org/mozilla-central/rev/aa8a99510c0686cdf9d42fb4b8f6d968884c961d/browser/components/urlbar/UrlbarView.sys.mjs#895-910

Comment 1

[Drew Willcoxon :adw]

Not sure I agree. I haven't tested either of those patches -- do they make non-native menus look exactly like native Mac menus? If so then great. If not, I don't want to replace a nice native menu with an uncanny value simulation.

Comment 2

[Dão Gottwald [:dao]]

(In reply to Drew Willcoxon :adw from comment #1)

Not sure I agree. I haven't tested either of those patches -- do they make non-native menus look exactly like native Mac menus? If so then great.

It's likely not pixel-perfect, but it should be so close that ordinary users wouldn't be able to tell the difference.

If not, I don't want to replace a nice native menu with an uncanny value simulation.

But that's how most of our UI works these days. Working around this on the basis of individual widgets when our native simulation falls short doesn't scale. Instead we should continue to make efforts like bug 1858349 and bug 1861671 so that all instances can benefit.

That said, I'm not sure if any of the layout/ and widget/ changes from https://phabricator.services.mozilla.com/D177355 should also be reverted. mstange?

Comment 3

[Markus Stange [:mstange]]

I agree that the non-native popup looks close enough these days that users wouldn't notice the difference much, so I am fine with removing this special case.

And then bug 1710459 will make it use a native popup again, if it ever gets done.

Comment 5

[Sam Johnson]

Attachment: Bug 1861950 - Remove urlbar result menu workaround on macOS. r?adw

After bug 1710459, openPopup(anchor) uses a native menu on macOS, so this workaround is no longer required and can be removed.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/29b1a26e8982
https://hg.mozilla.org/integration/autoland/rev/65dbe0485058
Remove urlbar result menu workaround on macOS. r=adw,urlbar-reviewers

Comment 7

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/65dbe0485058