1831792 - Scrollbar and button style issue in OpenPGP dialog (localized build, DE)

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Sören Hentzschel]

Attachment: screenshot

STR:

1. Make sure that you have OpenPGP configured and that you're using a language with longer words than English, for example German. English builds are not affected.
2. Open a signed message.
3. Press the OpenPGP button in the message header.

Actual:

The button text is much longer than the button itself and the panel can be scrolled.

Expected:

No scrollbar and no style issue with the button.

Unfortunately mozregression does not support localized Thunderbird builds and I didn't use OpenPGP before so I don't know if it's a regression. Tested in Thunderbird Daily 114.0a1 (2023-05-07) on macOS 13.3.1.

Comment 1

[Thomas D. (:thomas8)]

Another bug with similar symptoms, labels bigger than their button, is bug Bug 1833978.

Alex, should we try to eliminate this in some systematic way to catch all instances? While it's not harmful, it does make us look pretty odd, and having to scroll an info panel for reading its text is also pretty painful, even if it's not everyone's scenario.
Flexbox?

Elizabeth fixed bug 1831790, another dialog too small!

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Bug 1831792 - Make the messageSecurityPanel a bit wider. r=#thunderbird-reviewers

Depends on D178581

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2924d70a9983
Make the messageSecurityPanel a bit wider so it would work better in all locales. r=mkmelin

Comment 4

[Sören Hentzschel]

Not fixed in Thunderbird Daily 115.0a1 (2023-05-23) on macOS, German Build. Yes, the dialog is wider now, but the button text is still larger than the button itself and there is still a scrollbar.

It doesn't look like a reliable fix to give a fixed width to the dialog. Did you test all languages? What if a translation changes in the future? Or if you decide to increase the padding of dialogs - will this specific dialog be tested again in all languages? So I guess the actual cause should be fixed instead, otherwise this issue can re-appear at any time and without some kind of UI test you won't notice it until someone reports it.

Comment 5

[Sören Hentzschel]

Attachment: screenshot

Comment 6

[Richard Marti (:Paenglab)]

For Mac it would need a width of 41rem to show the button correctly. But there could be other locales that need even more space. Should we change this button to a link that can wrap?

Comment 7

[Alessandro Castellani [:aleca]]

No, we should make that container flex-wrap: wrap so if the content doesn't fit elements can stack naturally.

Comment 8

[Richard Marti (:Paenglab)]

Attachment: Bug 1831792 - Let the security key container wrap when too long. r=#thunderbird-front-end-reviewers

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c3d8a8673e5d
Let the security key container wrap when too long. r=freaktechnik