Open Bug 1821304 Opened 1 year ago Updated 3 months ago

[meta] Fix Thunderbird flexbox regressions

Categories

(Thunderbird :: Upstream Synchronization, defect)

Thunderbird 112
defect

Tracking

(thunderbird_esr102 unaffected)

112 Branch
Tracking Status
thunderbird_esr102 --- unaffected

People

(Reporter: elijmitchell, Unassigned)

References

(Depends on 2 open bugs, Regression)

Details

(Keywords: meta, regression)

Attachments

(1 obsolete file)

Meta bug to track the effort to fix and port all the layout regressions cased by bug 1820534, when mozilla-central moved to flexbox.

Martin Giger [:freaktechnik] from comment 4 in bug 1820744:

Things still broken after the patch:

  • Today pane toggle day alignment is wrong
  • The panel subview header is massive (open any submenu in the app menu)
  • The chat conversation list action buttons are not correctly aligned
  • Chat layout was behaving weird (seems ok atm), but it's been weird since flex emulation, so needs more work anyway
  • Input sizes in chat account settings (authentication settings, default channels) is broken

I expect there's more that I didn't spot.

Martin Giger [:freaktechnik]:

we could fairly easily replace all <box>, <hobx> and <vbox> with a div that has a class that has display: flex and the appropriate direction

See Also: → 1818254
See Also: → 1809084
Assignee: nobody → elizabeth
Status: NEW → ASSIGNED
Keywords: leave-open

Running list of fixes needed:

  • Today pane toggle day alignment is wrong
  • The panel subview header is massive (open any submenu in the app menu) - fixed in D172130
  • The chat conversation list action buttons are not correctly aligned
  • Chat layout was behaving weird (seems ok atm), but it's been weird since flex emulation, so needs more work anyway
  • Input sizes in chat account settings (authentication settings, default channels) is broken
See Also: → 1821377
Target Milestone: --- → 112 Branch
Attachment #9322134 - Attachment description: Bug 1821304: Fix size of submenu items. r=#thunderbird-front-end-reviewers → Bug 1821304: Fix size of submenu items. r=freaktechnik
Depends on: 1821405

Comment on attachment 9322134 [details]
Bug 1821304: Fix size of submenu items. r=freaktechnik

Revision D172130 was moved to bug 1821405. Setting attachment 9322134 [details] to obsolete.

Attachment #9322134 - Attachment is obsolete: true
Assignee: elizabeth → nobody
Status: ASSIGNED → NEW
See Also: → 1821451
Depends on: 1821451, 1821377
No longer depends on: 1820744
See Also: 1809084, 1821377, 1821451
No longer blocks: 1819328
Depends on: 1819328
Depends on: 1821603
Regressed by: 1821603
Regressed by: 1820744
No longer regressed by: 1821603
Depends on: 1821605
No longer blocks: 1821611
Depends on: 1821611
Depends on: 1821630
Depends on: 1821667
Depends on: 1822053
Depends on: 1822252
Depends on: 1822638
Depends on: 1822661
Depends on: 1822859
Depends on: 1822981
Depends on: 1822967
Depends on: 1823022
Depends on: 1823248
Depends on: 1823292
Depends on: 1823309
Depends on: 1823879
Depends on: 1823744
Depends on: 1817302
Depends on: 1823181
Depends on: 1823157
Depends on: 1826700
Depends on: 1826722
Depends on: 1826881
Depends on: 1834375
Depends on: 1817299
Depends on: 1836736
Depends on: 1836058
Depends on: 1838341
Depends on: 1838483
Depends on: 1838677
Depends on: 1836214
Depends on: 1848261
Regressions: 1852682
Depends on: 1854137
Depends on: 1854836
Depends on: 1855864
Depends on: 1844729
Depends on: 1889383
Depends on: 1869167
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: