Closed Bug 1831812 Opened 2 years ago Closed 1 year ago

Add test for "other" object in the contextual services Suggest engagement event

Categories

(Firefox :: Address Bar, task, P3)

task

Tracking

()

RESOLVED FIXED

People

(Reporter: adw, Unassigned)

References

Details

In the contextservices.quicksuggest.engagement event for Suggest, the event object will be "other" when a result is engaged with in some way not covered by the other values, for example, when a command other than dismiss and help is clicked in the result menu. This is currently untested so we should add a test or task for it -- https://searchfox.org/mozilla-central/source/browser/components/urlbar/tests/quicksuggest/browser/browser_telemetry_other.js would be a good place. Alternatively, this might be covered by fixing bug 1820825, since porting those tests to the result menu will cause "other" to be recorded for result menu commands other than dismiss and help. I'll add a dependency on that bug for now.

Bug 1820825 did fix this by modifying the weather telemetry test. Ideally "other" would have its own dedicated test/task, but since this is legacy telemetry I'm not sure DS even uses anymore, that's probably sufficient.

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.