1820825 - Make quicksuggest telemetry tests work with the result menu

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Dão Gottwald [:dao]]

Spinning this off from bug 1790020. These tests currently have the result menu disabled via:

https://searchfox.org/mozilla-central/rev/3002762e41363de8ee9ca80196d55e79651bcb6b/browser/components/urlbar/tests/quicksuggest/browser/head.js#99-107

Comment 1

[Dão Gottwald [:dao]]

Attachment: WIP: Bug 1820825 - Make quicksuggest telemetry tests work with the result menu.

Comment 2

[Dão Gottwald [:dao]]

Hey Drew, I'm trying to update quicksuggest tests that use setUpTelemetryTest: https://searchfox.org/mozilla-central/search?q=setUpTelemetryTest&case=true&path=
I've a attached a WIP / strawman patch in attachment 9323000 [details]. It's not particularly pretty and also doesn't work, although I imagine it could be fixed up if we want to go down that path. How do you think I should approach updating these tests?

Comment 3

[Drew Willcoxon :adw]

Thanks for asking. I think we should replace the selectables param with commands, and then tests would specify "dismiss" instead of "urlbarView-button-block" and "help" instead of "urlbarView-button-help". For "urlbarView-row-inner", I think doTelemetryTest() can just assume each row is clickable and each test needs to click it, and there can be another param to specify the expected telemetry for that, like click or row or something.

That way each test doesn't need to worry about whether the menu is enabled or not. That logic would live in doTelemetryTest() and its helpers. If the menu is enabled, then for each of the commands, open the menu and click the relevant menu item; otherwise, convert "dismiss" to "urlbarView-button-block", etc., and click that button.

But hopefully we can remove the individual buttons in favor of the menu soon?

Comment 4

[Drew Willcoxon :adw]

Stealing this

Comment 5

[Drew Willcoxon :adw]

Attachment: Bug 1820825 - Make quicksuggest telemetry tests work with the result menu.

We may be able to remove some or all of this legacy telemetry, and the Glean
telemetry should maybe be moved to the other Glean tests, but for now I'd like
to focus on getting rid of the resultMenu pref.

Depends on D190746

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6c0f50f8b8f
Make quicksuggest telemetry tests work with the result menu. r=dao

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b6c0f50f8b8f