Closed Bug 1831904 Opened 2 years ago Closed 23 days ago

Intermittent devtools/client/debugger/test/mochitest/browser_dbg-custom-formatters.js | single tracking bug

Categories

(DevTools :: Debugger, defect, P5)

defect

Tracking

(firefox-esr128 wontfix, firefox133 wontfix, firefox134 wontfix, firefox135 wontfix, firefox136 wontfix)

RESOLVED INCOMPLETE
Tracking Status
firefox-esr128 --- wontfix
firefox133 --- wontfix
firefox134 --- wontfix
firefox135 --- wontfix
firefox136 --- wontfix

People

(Reporter: intermittent-bug-filer, Unassigned)

References

(Regression)

Details

(Keywords: intermittent-failure, intermittent-testcase, regression, Whiteboard: [stockwell disabled])

Attachments

(1 file, 1 obsolete file)

Filed by: ctuns [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=414937768&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/E4ENrRbgTYqufgc4IOA5xQ/runs/0/artifacts/public/logs/live_backing.log


[task 2023-05-08T14:51:56.556Z] 14:51:56     INFO - TEST-START | devtools/client/debugger/test/mochitest/browser_dbg-custom-formatters.js
[task 2023-05-08T14:51:56.605Z] 14:51:56     INFO - GECKO(1600) | [Parent 1600, Main Thread] WARNING: IPC Connection Error: [Parent][PProfilerParent] RunMessage(msgname=PProfiler::Reply_Stop) Channel closing: too late to send/recv, messages will be lost: file /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1927
[task 2023-05-08T14:51:56.735Z] 14:51:56     INFO - GECKO(1600) | [Parent 1600, Compositor] WARNING: IPC Connection Error: [Parent][PCompositorManagerParent] RunMessage(msgname=PCompositorBridge::Msg___delete__) Channel closing: too late to send/recv, messages will be lost: file /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1927
[task 2023-05-08T14:51:56.736Z] 14:51:56     INFO - GECKO(1600) | [Parent 1600, Compositor] WARNING: IPC Connection Error: [Parent][PImageBridgeParent] RunMessage(msgname=PImageBridge::Msg_WillClose) Channel closing: too late to send/recv, messages will be lost: file /builds/worker/checkouts/gecko/ipc/glue/MessageChannel.cpp:1927
[task 2023-05-08T14:51:56.774Z] 14:51:56     INFO - GECKO(1600) | [Child 5770, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp:3426
[task 2023-05-08T14:51:56.790Z] 14:51:56     INFO - GECKO(1600) | [Child 5770, Main Thread] WARNING: NS_ENSURE_TRUE(InitStaticMembers()) failed: file /builds/worker/workspace/obj-build/dist/include/mozilla/Preferences.h:129
[task 2023-05-08T14:51:56.806Z] 14:51:56     INFO - GECKO(1600) | [Child 5770, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:4688
[task 2023-05-08T14:51:56.893Z] 14:51:56     INFO - GECKO(1600) | [Child 5778, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp:3426
[task 2023-05-08T14:51:56.896Z] 14:51:56     INFO - GECKO(1600) | [Child 5778, Main Thread] WARNING: NS_ENSURE_TRUE(InitStaticMembers()) failed: file /builds/worker/workspace/obj-build/dist/include/mozilla/Preferences.h:129
[task 2023-05-08T14:51:56.902Z] 14:51:56     INFO - GECKO(1600) | [Child 5778, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:4688
[task 2023-05-08T14:51:56.918Z] 14:51:56     INFO - GECKO(1600) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpevug5j_w.mozrunner/runtests_leaks_tab_pid5826.log
[task 2023-05-08T14:51:56.919Z] 14:51:56     INFO - GECKO(1600) | [5826, Main Thread] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /builds/worker/checkouts/gecko/tools/profiler/core/platform.cpp:345
[task 2023-05-08T14:51:56.924Z] 14:51:56     INFO - GECKO(1600) | [Child 5826, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/toolkit/xre/nsXREDirProvider.cpp:475
[task 2023-05-08T14:51:56.947Z] 14:51:56     INFO - GECKO(1600) | [Child 5776, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp:3426
[task 2023-05-08T14:51:56.950Z] 14:51:56     INFO - GECKO(1600) | [Child 5776, Main Thread] WARNING: NS_ENSURE_TRUE(InitStaticMembers()) failed: file /builds/worker/workspace/obj-build/dist/include/mozilla/Preferences.h:129
[task 2023-05-08T14:51:56.958Z] 14:51:56     INFO - GECKO(1600) | [Child 5776, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:4688
[task 2023-05-08T14:51:56.966Z] 14:51:56     INFO - GECKO(1600) | [Child 5826, Main Thread] WARNING: could not set real-time limit in CubebUtils::InitLibrary: file /builds/worker/checkouts/gecko/dom/media/CubebUtils.cpp:655
[task 2023-05-08T14:51:56.982Z] 14:51:56     INFO - GECKO(1600) | [Child 5826, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/toolkit/xre/nsXREDirProvider.cpp:475
[task 2023-05-08T14:51:56.983Z] 14:51:56     INFO - GECKO(1600) | [Child 5826, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/toolkit/xre/nsXREDirProvider.cpp:475
[task 2023-05-08T14:51:57.171Z] 14:51:57     INFO - GECKO(1600) | [Child 5826: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7f7130c2fc00 == 1 [pid = 5826] [id = 0]
[task 2023-05-08T14:51:57.171Z] 14:51:57     INFO - GECKO(1600) | [Child 5826: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 1 (7f7135e66090) [pid = 5826] [serial = 1] [outer = 0]
[task 2023-05-08T14:51:57.173Z] 14:51:57     INFO - GECKO(1600) | [Child 5826: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (7f7130c30400) [pid = 5826] [serial = 2] [outer = 7f7135e66090]
[task 2023-05-08T14:51:57.238Z] 14:51:57     INFO - GECKO(1600) | [Child 5826, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/toolkit/xre/nsXREDirProvider.cpp:475
[task 2023-05-08T14:51:59.778Z] 14:51:59     INFO - GECKO(1600) | [Child 1816: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (7fb90952f000) [pid = 1816] [serial = 38] [outer = 0] [url = about:blank]
[task 2023-05-08T14:52:00.460Z] 14:52:00     INFO - GECKO(1600) | [Parent 1600, Main Thread] WARNING: NS_ENSURE_TRUE(!mHasOrHasHadOwnerWindow || mOwnerWindow) failed: file /builds/worker/checkouts/gecko/dom/events/DOMEventTargetHelper.cpp:302
[task 2023-05-08T14:52:00.461Z] 14:52:00     INFO - GECKO(1600) | [Parent 1600, Main Thread] WARNING: NS_ENSURE_TRUE(!mHasOrHasHadOwnerWindow || mOwnerWindow) failed: file /builds/worker/checkouts/gecko/dom/events/DOMEventTargetHelper.cpp:302
[task 2023-05-08T14:52:00.463Z] 14:52:00     INFO - GECKO(1600) | [Parent 1600, Main Thread] WARNING: NS_ENSURE_TRUE(!mHasOrHasHadOwnerWindow || mOwnerWindow) failed: file /builds/worker/checkouts/gecko/dom/events/DOMEventTargetHelper.cpp:302
[task 2023-05-08T14:52:00.464Z] 14:52:00     INFO - GECKO(1600) | [Parent 1600, Main Thread] WARNING: NS_ENSURE_TRUE(!mHasOrHasHadOwnerWindow || mOwnerWindow) failed: file /builds/worker/checkouts/gecko/dom/events/DOMEventTargetHelper.cpp:302
[task 2023-05-08T14:52:00.466Z] 14:52:00     INFO - GECKO(1600) | [Parent 1600: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 29 (7fb1f45edbb0) [pid = 1600] [serial = 263] [outer = 0] [url = chrome://devtools/content/debugger/index.html]
[task 2023-05-08T14:52:00.467Z] 14:52:00     INFO - GECKO(1600) | [Parent 1600: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 28 (7fb1e1913090) [pid = 1600] [serial = 260] [outer = 0] [url = about:devtools-toolbox]
[task 2023-05-08T14:52:04.797Z] 14:52:04     INFO - GECKO(1600) | [Parent 1600: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 27 (7fb1e190b800) [pid = 1600] [serial = 262] [outer = 0] [url = about:devtools-toolbox]
[task 2023-05-08T14:52:04.799Z] 14:52:04     INFO - GECKO(1600) | [Parent 1600: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 26 (7fb1ebfce800) [pid = 1600] [serial = 264] [outer = 0] [url = about:blank]
[task 2023-05-08T14:52:04.867Z] 14:52:04     INFO - GECKO(1600) | [Child 1725: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7fb2df826c00 == 0 [pid = 1725] [id = 20] [url = about:blank]
[task 2023-05-08T14:52:09.015Z] 14:52:09     INFO - GECKO(1600) | [Child 1725: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (7fb2e576d850) [pid = 1725] [serial = 44] [outer = 0] [url = about:blank]
[task 2023-05-08T14:52:13.090Z] 14:52:13     INFO - GECKO(1600) | [Child 1725: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (7fb2df827000) [pid = 1725] [serial = 45] [outer = 0] [url = about:blank]
[task 2023-05-08T14:53:26.746Z] 14:53:26     INFO - TEST-INFO | started process screentopng
[task 2023-05-08T14:53:26.988Z] 14:53:26     INFO - TEST-INFO | screentopng: exit 0
[task 2023-05-08T14:53:26.988Z] 14:53:26     INFO - Buffered messages logged at 14:51:56
[task 2023-05-08T14:53:26.988Z] 14:53:26     INFO - Entering test bound 
[task 2023-05-08T14:53:26.989Z] 14:53:26     INFO - Adding a new tab with URL: https://example.com/browser/devtools/client/debugger/test/mochitest/examples/doc_dbg-custom-formatters.html
[task 2023-05-08T14:53:26.989Z] 14:53:26     INFO - Buffered messages finished
[task 2023-05-08T14:53:26.989Z] 14:53:26     INFO - TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-custom-formatters.js | Test timed out - 
[task 2023-05-08T14:53:26.989Z] 14:53:26     INFO - Removing tab.
[task 2023-05-08T14:53:26.990Z] 14:53:26     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2023-05-08T14:53:26.991Z] 14:53:26     INFO - Got event: 'TabClose' on [object XULElement].
[task 2023-05-08T14:53:26.991Z] 14:53:26     INFO - Tab removed and finished closing
[task 2023-05-08T14:53:26.992Z] 14:53:26     INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-custom-formatters.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2023-05-08T14:53:26.993Z] 14:53:26     INFO - GECKO(1600) | [Child 5826: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7f7130c2fc00 == 0 [pid = 5826] [id = 0] [url = about:blank]
[task 2023-05-08T14:53:26.994Z] 14:53:26     INFO - GECKO(1600) | [Child 5826: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (7f7130c30400) [pid = 5826] [serial = 2] [outer = 0] [url = about:blank]
[task 2023-05-08T14:53:26.994Z] 14:53:26     INFO - GECKO(1600) | [Child 5826: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (7f7135e66090) [pid = 5826] [serial = 1] [outer = 0] [url = about:blank]
[task 2023-05-08T14:53:26.994Z] 14:53:26     INFO - GECKO(1600) | [Child 5826, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp:3426
[task 2023-05-08T14:53:26.995Z] 14:53:26     INFO - GECKO(1600) | [Child 5826, Main Thread] WARNING: NS_ENSURE_TRUE(InitStaticMembers()) failed: file /builds/worker/workspace/obj-build/dist/include/mozilla/Preferences.h:129
[task 2023-05-08T14:53:26.997Z] 14:53:26     INFO - GECKO(1600) | [Child 5826, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:4688
[task 2023-05-08T14:53:27.235Z] 14:53:27     INFO - GECKO(1600) | MEMORY STAT | vsize 4229MB | residentFast 730MB | heapAllocated 357MB
[task 2023-05-08T14:53:27.237Z] 14:53:27     INFO - TEST-OK | devtools/client/debugger/test/mochitest/browser_dbg-custom-formatters.js | took 90681ms
[task 2023-05-08T14:53:27.250Z] 14:53:27     INFO - GECKO(1600) | [Child 1725: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7fb2df826000 == 1 [pid = 1725] [id = 21]
[task 2023-05-08T14:53:27.251Z] 14:53:27     INFO - GECKO(1600) | [Child 1725: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 1 (7fb2e576d090) [pid = 1725] [serial = 46] [outer = 0]
[task 2023-05-08T14:53:27.252Z] 14:53:27     INFO - GECKO(1600) | [Child 1725: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (7fb2df826400) [pid = 1725] [serial = 47] [outer = 7fb2e576d090]
[task 2023-05-08T14:53:27.287Z] 14:53:27     INFO - checking window state
[task 2023-05-08T14:53:27.337Z] 14:53:27     INFO - TEST-START | devtools/client/debugger/test/mochitest/browser_dbg-debug-line.js
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Attachment #9385412 - Attachment is obsolete: true
Status: REOPENED → RESOLVED
Closed: 2 years ago10 months ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---

this test is failing on macosx 14.70 while testing out on try upgrading from 10.15.

from a log, I see:

[task 2024-12-17T13:35:18.541Z] 13:35:18     INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-custom-formatters.js | Found token <xyz> on 26:16 - 
[task 2024-12-17T13:35:18.541Z] 13:35:18     INFO - Hovering on token <xyz>
[task 2024-12-17T13:35:18.542Z] 13:35:18     INFO - Buffered messages logged at 13:35:18
[task 2024-12-17T13:35:18.543Z] 13:35:18     INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-custom-formatters.js | Popup preview text shown to user. Got: CUSTOM Expected: CUSTOM - 
[task 2024-12-17T13:35:18.543Z] 13:35:18     INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-custom-formatters.js | 'xyz' is expandable - 
[task 2024-12-17T13:35:18.543Z] 13:35:18     INFO - Expanding 'xyz'
[task 2024-12-17T13:35:18.544Z] 13:35:18     INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-custom-formatters.js | The tooltip variable body is custom formatted - 
[task 2024-12-17T13:35:18.545Z] 13:35:18     INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-custom-formatters.js | The tooltip variable body text is correct - 
[task 2024-12-17T13:35:18.545Z] 13:35:18     INFO - Resuming from 27
[task 2024-12-17T13:35:18.546Z] 13:35:18     INFO - Waiting for the debugger to resume
[task 2024-12-17T13:35:18.546Z] 13:35:18     INFO - Waiting for state change: 
[task 2024-12-17T13:35:18.547Z] 13:35:18     INFO - Finished waiting for state change: 
[task 2024-12-17T13:35:18.547Z] 13:35:18     INFO - Buffered messages finished
[task 2024-12-17T13:35:18.553Z] 13:35:18     INFO - TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-custom-formatters.js | A promise chain failed to handle a rejection: Debugger internal exception: Preview for <html > threw a ReferenceError - stack: getPausedPreview/<@resource://devtools/client/debugger/src/actions/preview.js:200:13
[task 2024-12-17T13:35:18.553Z] 13:35:18     INFO - async*thunk/</</<@resource://devtools/client/debugger/src/actions/utils/middleware/thunk.js:29:45
[task 2024-12-17T13:35:18.553Z] 13:35:18     INFO - bindActionCreator/<@resource://devtools/client/shared/vendor/redux.js:520:12
[task 2024-12-17T13:35:18.553Z] 13:35:18     INFO - Preview/<@resource://devtools/client/debugger/src/components/Editor/Preview/index.js:67:27
[task 2024-12-17T13:35:18.553Z] 13:35:18     INFO - _emit@resource://devtools/shared/event-emitter.js:242:32
[task 2024-12-17T13:35:18.553Z] 13:35:18     INFO - emit@resource://devtools/shared/event-emitter.js:186:18
[task 2024-12-17T13:35:18.553Z] 13:35:18     INFO - emit@resource://devtools/shared/event-emitter.js:330:18
[task 2024-12-17T13:35:18.553Z] 13:35:18     INFO - _dispatch@resource://devtools/client/debugger/src/utils/editor/tokens.js:69:12
[task 2024-12-17T13:35:18.553Z] 13:35:18     INFO - onMouseOver/<@resource://devtools/client/debugger/src/utils/editor/tokens.js:124:16
[task 2024-12-17T13:35:18.553Z] 13:35:18     INFO - #createEventHandlers/eventHandlers[eventName]/<@resource://devtools/client/shared/sourceeditor/editor.js:1031:20
[task 2024-12-17T13:35:18.553Z] 13:35:18     INFO - setTimeout handler*#createEventHandlers/eventHandlers[eventName]@resource://devtools/client/shared/sourceeditor/editor.js:1026:36
[task 2024-12-17T13:35:18.553Z] 13:35:18     INFO - Pn/<@resource://devtools/client/shared/sourceeditor/codemirror6/codemirror6.bundle.mjs:1:109091
[task 2024-12-17T13:35:18.553Z] 13:35:18     INFO - runHandlers@resource://devtools/client/shared/sourceeditor/codemirror6/codemirror6.bundle.mjs:1:107333
[task 2024-12-17T13:35:18.553Z] 13:35:18     INFO - handleEvent@resource://devtools/client/shared/sourceeditor/codemirror6/codemirror6.bundle.mjs:1:107167

we will disable this for now to do the migration.

See Also: → 1937149
Whiteboard: [stockwell disable-recommended]
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
Keywords: leave-open

This frequently fails on CI because a previous test moves the cursor to certain coordinates which later will attempt to trigger a preview in the debugger source editor. However the cursor will be hovering a token typically not available in scope such as html.

https://searchfox.org/mozilla-central/rev/d816941cb362ad2669de8425b6d208f6c142a621/devtools/client/debugger/src/actions/preview.js#196-201

if (hasException) {
  const errorClass = exception?.getGrip()?.class || "Error";
  throw new Error(
    `Debugger internal exception: Preview for <${expression}> threw a ${errorClass}`
  );
}

Typically in such cases, the error will simply be ${expression} is not defined, and it happens anytime you hover an out of scope token while paused.

Nicolas, Bomsy, I think there were discussions around handling preview for out of scope lines differently? Is there a bug for this? It would address this intermittent so we should unskip the test at the same time. Otherwise I'm not sure what we should do. This most likely regressed with Bug 1873150 when we started throwing for evaluation errors.

Flags: needinfo?(nchevobbe)
Flags: needinfo?(hmanilla)
Keywords: regression
Regressed by: 1873150
Pushed by agoloman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/83a047d5aa95 disable browser_dbg-custom-formatters.js on windows 11 for frequent failures. r=devtools-reviewers,jdescottes DONTBUILD

Set release status flags based on info from the regressing bug 1873150

Pushed by agoloman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/355331601a27 fix typo in manifest file. a=typo-fix CLOSED TREE

(In reply to Julian Descottes [:jdescottes] from comment #80)

This frequently fails on CI because a previous test moves the cursor to certain coordinates which later will attempt to trigger a preview in the debugger source editor. However the cursor will be hovering a token typically not available in scope such as html.

https://searchfox.org/mozilla-central/rev/d816941cb362ad2669de8425b6d208f6c142a621/devtools/client/debugger/src/actions/preview.js#196-201

if (hasException) {
  const errorClass = exception?.getGrip()?.class || "Error";
  throw new Error(
    `Debugger internal exception: Preview for <${expression}> threw a ${errorClass}`
  );
}

Typically in such cases, the error will simply be ${expression} is not defined, and it happens anytime you hover an out of scope token while paused.

Nicolas, Bomsy, I think there were discussions around handling preview for out of scope lines differently? Is there a bug for this? It would address this intermittent so we should unskip the test at the same time. Otherwise I'm not sure what we should do. This most likely regressed with Bug 1873150 when we started throwing for evaluation errors.

Not sure about the bug you're referencing, bomsy might know. For the error we throw, the initial version of the patch for Bug 1873150 was only checking for SyntaxError specifically: https://phabricator.services.mozilla.com/D197762?vs=on&id=806044#toc

I feel like we could go back to this maybe? Or maybe, we could simply console.warn/error and return instead of throwing? I don't know if there's a lot of values throwing here

Flags: needinfo?(nchevobbe)

Set release status flags based on info from the regressing bug 1873150

Flags: needinfo?(hmanilla)
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Status: REOPENED → RESOLVED
Closed: 3 months ago23 days ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: