1873150 - throw when getPreview expression evaluation has a SyntaxError

Status: RESOLVED FIXED

(DevTools :: Debugger, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

This will help us track cases where we shouldn't try to evaluate in the first place

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1873150 - [devtools] Throw in getPreview if evaluated expression has syntax error. r=ochameau.

This will allow us to be notified about expression we shouldn't try to evaluate.

Depends on D197585

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:nchevobbe, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

there's a comment on the patch I need to get back to

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d24cd5b7ed54
[devtools] Throw in getPreview if evaluated expression has syntax error. r=ochameau,devtools-reviewers.

Comment 5

[Iulian Moraru]

Backed out (bug 1873150) for causing mass build bustages.

• Push with failures

• Failure log

• Backout link

[task 2024-06-04T10:17:09.269Z] 10:17:09     INFO -  gmake[3]: Entering directory '/builds/worker/workspace/obj-build'
[task 2024-06-04T10:17:09.271Z] 10:17:09     INFO -  /builds/worker/.mozbuild/srcdirs/gecko-8a5b87fe5d69/_virtualenvs/build/bin/python -m mozbuild.action.file_generate /builds/worker/checkouts/gecko/python/mozbuild/mozbuild/action/node.py generate devtools/client/debugger/src/actions/node.stub devtools/client/debugger/src/actions/.deps/node.stub.pp devtools/client/debugger/src/actions/.deps/node.stub.stub /builds/worker/checkouts/gecko/devtools/client/shared/build/build.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/event-listeners.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/exceptions.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/expressions.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/file-search.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/index.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/navigation.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/preview.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/project-text-search.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/quick-open.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/source-actors.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/sources-tree.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/tabs.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/toolbox.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/tracing.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/threads.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/ui.js /builds/worker/workspace/obj-build//dist/bin/browser/chrome/devtools/modules/devtools/client/debugger/src/actions
[task 2024-06-04T10:17:09.273Z] 10:17:09     INFO -  Executing "/builds/worker/fetches/node/bin/node /builds/worker/checkouts/gecko/devtools/client/shared/build/build.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/event-listeners.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/exceptions.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/expressions.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/file-search.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/index.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/navigation.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/preview.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/project-text-search.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/quick-open.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/source-actors.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/sources-tree.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/tabs.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/toolbox.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/tracing.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/threads.js /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/ui.js /builds/worker/workspace/obj-build//dist/bin/browser/chrome/devtools/modules/devtools/client/debugger/src/actions"
[task 2024-06-04T10:17:09.275Z] 10:17:09    ERROR -  b'/builds/worker/checkouts/gecko/devtools/client/shared/build/build.js:31\n    throw new Error(`\n    ^\n\nError: \n========================\nNODE COMPILATION ERROR!\n\nFile:   /builds/worker/checkouts/gecko/devtools/client/debugger/src/actions/preview.js\nStack:\n\nSyntaxError: unknown: Unexpected token, expected "}" (96:37)\n\n  94 |       throw new Error(\n  95 |         `Debugger internal exception: Preview for <${expression}> threw a ${\n> 96 |           exception?.getGrip()?.class || "Error"\n     |                                      ^\n  97 |         }`\n  98 |       );\n  99 |     }\n    at r._raise (/builds/worker/checkouts/gecko/devtools/client/shared/build/babel.js:1:432330)\n    at r.raiseWithData (/builds/worker/checkouts/gecko/devtools/client/shared/build/babel.js:1:432259)\n    at r.raise (/builds/worker/checkouts/gecko/devtools/client/shared/build/babel.js:1:431979)\n    at r.unexpected (/builds/worker/checkouts/gecko/devtools/client/shared/build/babel.js:1:562232)\n    at r.expect (/builds/worker/checkouts/gecko/devtools/client/shared/build/babel.js:1:561934)\n    at r.parseTemplate (/builds/worker/checkouts/gecko/devtools/client/shared/build/babel.js:1:601619)\n    at r.parseExprAtom (/builds/worker/checkouts/gecko/devtools/client/shared/build/babel.js:1:595613)\n    at r.parseExprSubscripts (/builds/worker/checkouts/gecko/devtools/client/shared/build/babel.js:1:588329)\n    at r.parseMaybeUnary (/builds/worker/checkouts/gecko/devtools/client/shared/build/babel.js:1:587891)\n    at r.parseExprOps (/builds/worker/checkouts/gecko/devtools/client/shared/build/babel.js:1:585130)\n\n========================\n\n    at transform (/builds/worker/checkouts/gecko/devtools/client/shared/build/build.js:31:11)\n    at Object.<anonymous> (/builds/worker/checkouts/gecko/devtools/client/shared/build/build.js:70:16)\n    at Module._compile (node:internal/modules/cjs/loader:1356:14)\n    at Module._extensions..js (node:internal/modules/cjs/loader:1414:10)\n    at Module.load (node:internal/modules/cjs/loader:1197:32)\n    at Module._load (node:internal/modules/cjs/loader:1013:12)\n    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)\n    at node:internal/main/run_main_module:28:49\n\nNode.js v18.19.0\n'
[task 2024-06-04T10:17:09.276Z] 10:17:09    ERROR -  gmake[3]: *** [backend.mk:1134: devtools/client/debugger/src/actions/.deps/node.stub.stub] Error 1
[task 2024-06-04T10:17:09.276Z] 10:17:09     INFO -  gmake[3]: Leaving directory '/builds/worker/workspace/obj-build'
[task 2024-06-04T10:17:09.278Z] 10:17:09     INFO -  gmake[3]: Entering directory '/builds/worker/workspace/obj-build'
[task 2024-06-04T10:17:09.279Z] 10:17:09     INFO -  ./node.stub.stub
[task 2024-06-04T10:17:09.279Z] 10:17:09     INFO -  gmake[3]: Leaving directory '/builds/worker/workspace/obj-build'

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

weird, something was off in debugger's build step

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bfac276cdbb
[devtools] Throw in getPreview if evaluated expression has syntax error. r=ochameau,devtools-reviewers.

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2bfac276cdbb