1832130 - Port bug 1508369: Add stylelint to Thunderbird CI and mach commlint

Status: RESOLVED FIXED

(Thunderbird :: Build Config, task)

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1832130 - Port bug 1508369: Add stylelint to mach commlint. r=#thunderbird-front-end-reviewers

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1832130 - Port bug 1508369: Automatic stylelint fixes. r=#thunderbird-front-end-reviewers

Depends on D178832

Comment 3

[Rob Lemley [:rjl]]

There are some files that won't auto-fix and I'm not 100% what to do with. Alex, can you have someone look please? (We do want to land this ASAP to avoid uplift problems with 115esr later on.)

/home/rob/moz/m-c/comm/calendar/base/themes/common/today-pane.css
122:52 error Unexpected missing generic font family font-family-no-missing-generic-family-keyword (stylelint)

/home/rob/moz/m-c/comm/mail/themes/osx/mail/mailWindow1.css
51:16 error Unexpected missing generic font family font-family-no-missing-generic-family-keyword (stylelint)

/home/rob/moz/m-c/comm/mail/themes/shared/mail/chat.css
917:38 error Unexpected missing generic font family font-family-no-missing-generic-family-keyword (stylelint)

/home/rob/moz/m-c/comm/mail/themes/shared/mail/panelUI.css
15:35 error Unexpected missing var function for "--menu-panel-width" custom-property-no-missing-var-function (stylelint)

/home/rob/moz/m-c/comm/mail/themes/shared/mail/tree-listbox.css
88:3 error Unexpected duplicate "--listbox-selected-color" declaration-block-no-duplicate-custom-properties (stylelint)

Comment 4

[Alessandro Castellani [:aleca]]

(In reply to Rob Lemley [:rjl] from comment #3)

/home/rob/moz/m-c/comm/calendar/base/themes/common/today-pane.css
122:52 error Unexpected missing generic font family font-family-no-missing-generic-family-keyword (stylelint)

/home/rob/moz/m-c/comm/mail/themes/osx/mail/mailWindow1.css
51:16 error Unexpected missing generic font family font-family-no-missing-generic-family-keyword (stylelint)

/home/rob/moz/m-c/comm/mail/themes/shared/mail/chat.css
917:38 error Unexpected missing generic font family font-family-no-missing-generic-family-keyword (stylelint)

For these 3 you can add a , sans-serif; fallback right at the end of those fonts lists.

/home/rob/moz/m-c/comm/mail/themes/shared/mail/panelUI.css
15:35 error Unexpected missing var function for "--menu-panel-width" custom-property-no-missing-var-function (stylelint)

Can we put a linter comment to ignore this? We need it as we're overriding an m-c variable only for that widget.

/home/rob/moz/m-c/comm/mail/themes/shared/mail/tree-listbox.css
88:3 error Unexpected duplicate "--listbox-selected-color" declaration-block-no-duplicate-custom-properties (stylelint)

Ah, good catch on this duplicate.
Richard, we got double declaration here: https://searchfox.org/comm-central/rev/5391ea879779884999142a67920e99c83ea356bd/mail/themes/shared/mail/tree-listbox.css#82-89

--listbox-selected-color: var(--listbox-color);
--listbox-selected-color: var(--sidebar-highlight-text-color, var(--selected-item-text-color));

I guess we should delete the first one, but just checking to make sure.

Comment 5

[Richard Marti (:Paenglab)]

(In reply to Alessandro Castellani [:aleca] from comment #4)

(In reply to Rob Lemley [:rjl] from comment #3)

/home/rob/moz/m-c/comm/mail/themes/shared/mail/tree-listbox.css
88:3 error Unexpected duplicate "--listbox-selected-color" declaration-block-no-duplicate-custom-properties (stylelint)

Ah, good catch on this duplicate.
Richard, we got double declaration here: https://searchfox.org/comm-central/rev/5391ea879779884999142a67920e99c83ea356bd/mail/themes/shared/mail/tree-listbox.css#82-89

--listbox-selected-color: var(--listbox-color);
--listbox-selected-color: var(--sidebar-highlight-text-color, var(--selected-item-text-color));

I guess we should delete the first one, but just checking to make sure.

Yes, the first one can be deleted.

Comment 6

[Rob Lemley [:rjl]]

Attachment: Bug 1832130 - Port bug 1508369: Manual stylelint fixes. r=#thunderbird-front-end-reviewers

Depends on D178833

Comment 7

[Rob Lemley [:rjl]]

Attachment: Bug 1832130 - Port bug 1508369: Add stylelint (css) linting to Thunderbird CI. r=#thunderbird-build-system-reviewers

Depends on D178855

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/129ddcf819cd
Port bug 1508369: Add stylelint to mach commlint. r=aleca
https://hg.mozilla.org/comm-central/rev/ce549fa3b0cf
Port bug 1508369: Automatic stylelint fixes. r=aleca
https://hg.mozilla.org/comm-central/rev/5d1a27e645b1
Port bug 1508369: Manual stylelint fixes. r=aleca

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/581cce6d1113
Port bug 1508369: Add stylelint (css) linting to Thunderbird CI. r=dandarnell