1832198 - Remove adM/Wikipedia suggestions from memory when they are disabled

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Drew Willcoxon :adw]

If adM/Wikipedia remote settings suggestions are enabled and then later disabled, they stick around in memory, in AdmWikipedia.#suggestionsMap. The map should be cleared or set to null, here in enable().

Unfortunately a lot of the tests accidentally rely on the current behavior where suggestions are not cleared, and that's why fixing this isn't trivial.

This bug is spun out from bug 1831656, see discussion in https://phabricator.services.mozilla.com/D176779#inline-981608

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1832198 - Remove Suggest suggestions from memory when their features are disabled.

This is simple to fix after the changes made in bug 1861540 D192038.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79de70379650
Remove Suggest suggestions from memory when their features are disabled. r=daisuke

Comment 3

[Norisz Fay [:noriszfay]]

Backed out for causing failures on browser_quicksuggest_mdn.js

Backout link

Push with failures

Failure log

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4d7e610b48d
Remove Suggest suggestions from memory when their features are disabled. r=daisuke

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e4d7e610b48d