1869054 - MDN and addon suggestions need to null-check their suggestion maps

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Drew Willcoxon :adw]

When addon and MDN suggestions are disabled, they clear their suggestion maps so that suggestions are removed from memory. This change was made in bug 1832198. However, the maps will be null at that time if the JS backend never finished a sync. That can happen if the Rust backend was enabled and then disabled, or if the JS backend is enabled and sync is just slow or didn't happen because the network is down or some similar reason.

I hit this by accident when I was testing something else, but I can't reproduce it easily. It requires addon or MDN suggestions to be enabled and then disabled, plus Rust to be enabled and then disabled or a slow RS sync. I don't think any users would hit this.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1869054 - Add some null checks to MDN and addon suggestion maps.

This is hard to test, and since this patch only adds a couple defensive null
checks I don't think it really needs one anyway.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/da54bb1e3730
Add some null checks to MDN and addon suggestion maps. r=daisuke

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/da54bb1e3730