1832261 - [CTW] Remove most of HTMLTable*Accessible

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

Now that Cache the World is enabled by default everywhere, we use CachedTableAccessible for HTML tables. We can get rid of most of the code in the HTMLTable*Accessible classes. However, there are still a few things we depend on there:

1. Calculation of the role for header cells.
2. Retrieval of the row/colspan from layout.

We need to work out whether we want to keep the classes, make these utility functions or something else. Ideally, we would get rid of TableAccessible and just have TableAccessibleBase, since having both is a little confusing and mostly unnecessary. However, that does make things awkward for the above cases, since we need some way of accessing that data from LocalAccessible.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1832261: Remove most of HTMLTable*Accessible.

We now use CachedTableAccessible for HTML tables, so much of the code in the HTMLTable*Accessible classes was unused.
However, we still depend on these classes for some data needed to build the cached table.

1. HTMLTableAccessible and HTMLTableCellAccessible no longer derive from TableAccessible and TableCellAccessible, respectively. Instead, callers which need specific access to HTML table data use the HTMLTable*Accessible class directly.
2. All table specific methods have been removed except those that provide data required to build a CachedTableAccessible. The remaining methods are those for querying the row/column span (which depends on layout) and getting the caption (which depends on DOM).
3. HTMLTableAccessible are now used for all <table>, <td>, <th> and <tr> elements and MathML equivalents. ARIAAccessible are never used for these elements. This improves consistency, simplifies the code and means that behavior specific to these HTML elements is handled in these classes, rather than in the ARIA classes as well.
4. The table, row and cell roles are now specified in HTMLMarkupMap and MathMLMarkupMap, rather than overriding NativeRole.
5. IsProbablyLayoutTable has been moved from TableAccessible to HTMLTableAccessible, as it is only relevant for HTML tables, not for ARIA tables.
6. HTMLTableHeaderCellAccessible::NativeRole has been rewritten such that it no longer depends on querying table coordinates, as that would now require building a CachedTableAccessible, which would be very wasteful here. This replaces TableCellAccessible::HeaderCellRole, which has been removed.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/956690fe06d1
Remove most of HTMLTable*Accessible. r=nlapre

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/956690fe06d1

Comment 4

[James Teh [:Jamie]]

Comment on attachment 9337201 [details]
Bug 1832261: Remove most of HTMLTable*Accessible.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Needed to fix various accessibility regressions introduced by the Cache the World project which shipped in 115.
• User impact if declined: Table accessibility bugs which impact popular sites (Google Calendar, Facebook Messenger) once other necessary fixes in other areas are uplifted.
• Fix Landed on Version: 116
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is a significant refactor. However, this is well covered by automated tests and has been baking on release since 116 without problems.

Comment 5

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/971b3bd86474

Comment 6

[Donal Meehan [:dmeehan]]

Comment on attachment 9337201 [details]
Bug 1832261: Remove most of HTMLTable*Accessible.

Approved for 115.4esr.