1835967 - Remove TableAccessibleBase::Select/UnselectRow/Col

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

1. Only IA2 supports these. No other platform API includes such methods.
2. NVDA doesn't use them.
3. Chrome doesn't implement the IA2 methods (so JAWS presumably doesn't use them either).
4. The behaviour for ARIA grids - mutating the aria-selected attribute - is obscure and violates the spec.
5. The behaviour for both HTML tables and ARIA grids is inconsistent between these methods and Accessible::SetSelected.
6. We don't implement them for CtW, nor do we have any plans to do so.
7. These methods are making the work to remove old table code (thus simplifying the code and paving the way for correctness fixes) much harder.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1835967: Remove TableAccessibleBase::Select/UnselectCol/Row.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c89afdd4175d
Remove TableAccessibleBase::Select/UnselectCol/Row. r=nlapre

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c89afdd4175d

Comment 4

[James Teh [:Jamie]]

Comment on attachment 9336683 [details]
Bug 1835967: Remove TableAccessibleBase::Select/UnselectCol/Row.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Needed to fix various accessibility regressions introduced by the Cache the World project which shipped in 115.
• User impact if declined: Needed by bug 1832261, which fixes some accessibility bugs with tables on some popular sites and is a prerequisite for fixes in other areas.
• Fix Landed on Version: 116
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Removes unused methods.

Comment 5

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/2a0e97470be5

Comment 6

[Donal Meehan [:dmeehan]]

Comment on attachment 9336683 [details]
Bug 1835967: Remove TableAccessibleBase::Select/UnselectCol/Row.

Approved for 115.4esr.