1832326 - Remove BodyStreamHolder::MarkAsRead

Status: RESOLVED FIXED

(Core :: DOM: Streams, task)

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1832326 - Part 1: Remove BodyStreamHolder::NullifyStream()/MarkAsRead() r=smaug

1. NullifyStream has been there forever since bug 1128959 probably to release the underlying source early, but that purpose is now fulfilled internally in dom/streams by ReadableStreamController::ClearAlgorithms which calls BodyStreamUnderlyingSourceAlgorithms::ReleaseObjects.
2. FetchBody currently has two source of truth for bodyUsed but per the spec it should just refer to ReadableStream::Disturbed(). Removing mBodyUsed would be more complex as there are several SetBodyUsed calls here and there, so this is only the first step to reduce the use of its own field but use the ReadableStream info directly.

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1832326 - Part 2: Remove FetchBody::mReadableStreamReader r=smaug

FetchBody does nothing with the strong reference. Both ReadableStream and FetchStreamReader have their strong references and corresponding cycle collection, so this one can go away.

Depends on D177904

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/955b1743858a
Part 1: Remove BodyStreamHolder::NullifyStream()/MarkAsRead() r=smaug
https://hg.mozilla.org/integration/autoland/rev/f1576a86a535
Part 2: Remove FetchBody::mReadableStreamReader r=smaug

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/955b1743858a
https://hg.mozilla.org/mozilla-central/rev/f1576a86a535