1832348 - Replace .panel-footer with moz-button-group

Status: RESOLVED FIXED

(Toolkit :: Themes, task)

Description

[Mark Striemer [:mstriemer]]

The .panel-footer class should only be used for buttons since it sets justify-content: flex-end, but it is very tempting to use it for other elements since it sets the padding as well

We should convert all of our .panel-footer uses to moz-button-group and remove all the CSS for .panel-footer

Comment 1

[Ganna]

Attachment: Bug 1832348 - Part 1: Replace .panel-footer with moz-button-group in editBookmarkPanel r=hjones

Comment 2

[Ganna]

Attachment: Bug 1832348 - Part 2: Replace .panel-footer with moz-button-group in translationsPanel r=hjones

Comment 3

[Ganna]

Attachment: Bug 1832348 - Part 3: Replace .panel-footer with moz-button-group in downloadsPanel r=hjones

Comment 4

[Ganna]

Attachment: Bug 1832348 - Part 4: Replace .panel-footer with moz-button-group in popupnotification r=hjones

Depends on D181313

Comment 5

[Ganna]

Attachment: Bug 1832348 - Part 6: Remove unused selectors. r=hjones

Depends on D183231

Comment 7

[Ganna]

Attachment: Bug 1832348 - Part 5: Add panel-footer-button class for buttons in protectionsPanel. r=tgiles,hjones

Depends on D183231

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fcc56c5fd7e4
Part 1: Replace .panel-footer with moz-button-group in editBookmarkPanel r=hjones,dao
https://hg.mozilla.org/integration/autoland/rev/a357b1c75148
Part 2: Replace .panel-footer with moz-button-group in translationsPanel r=hjones,dao
https://hg.mozilla.org/integration/autoland/rev/fdcd11e66071
Part 3: Replace .panel-footer with moz-button-group in downloadsPanel r=dao,mak
https://hg.mozilla.org/integration/autoland/rev/9cc22e70d293
Part 4: Replace .panel-footer with moz-button-group in popupnotification r=hjones
https://hg.mozilla.org/integration/autoland/rev/294d38c19889
Part 5: Add panel-footer-button class for buttons in protectionsPanel. r=mstriemer
https://hg.mozilla.org/integration/autoland/rev/50f0546e5e0e
Part 6: Remove unused selectors. r=hjones,desktop-theme-reviewers,dao

Comment 9

[Atila Butkovits]

Backed out for causing mochitest failures with leaks.

Backout link: https://hg.mozilla.org/integration/autoland/rev/187364ed8fd0151f17dcfc4e65da9d084a1a2ecf

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=50f0546e5e0e83323d93aa631e2678484c13bcc8

Failure logs:
Leaks: https://treeherder.mozilla.org/logviewer?job_id=423934587&repo=autoland&lineNumber=29428
Mochitest: https://treeherder.mozilla.org/logviewer?job_id=423934921&repo=autoland&lineNumber=54400
Mochitest: https://treeherder.mozilla.org/logviewer?job_id=423935643&repo=autoland&lineNumber=4839

Comment 10

[Ganna]

Attachment: Bug 1832348 - Part 4: Add panel-footer-button class for panel-footer buttons in popupnotification. r=tgiles,hjones

Comment 11

[Phabricator Automation]

Comment on attachment 9343194 [details]
Bug 1832348 - Part 4: Replace .panel-footer with moz-button-group in popupnotification r=hjones

Revision D183231 was moved to bug 1849192. Setting attachment 9343194 [details] to obsolete.

Comment 12

[Dão Gottwald [:dao]]

Canceling old needinfo as this is showing up in the triage dashboard, and Ganna seems to be aware of the backout from a month ago. Hanna, do you know if this is ready to reland?

Comment 13

[Ganna]

(In reply to Dão Gottwald [:dao] from comment #12)

Canceling old needinfo as this is showing up in the triage dashboard, and Ganna seems to be aware of the backout from a month ago. Hanna, do you know if this is ready to reland?

There's still an issue with browser_popupNotification_security_delay.js failing after adding moz-button-group to popupnotification.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/001ee53a42dc
Part 1: Replace .panel-footer with moz-button-group in editBookmarkPanel r=hjones,dao
https://hg.mozilla.org/integration/autoland/rev/8356d7123645
Part 2: Replace .panel-footer with moz-button-group in translationsPanel r=hjones,dao
https://hg.mozilla.org/integration/autoland/rev/33d0d6f78d41
Part 3: Replace .panel-footer with moz-button-group in downloadsPanel r=dao,mak
https://hg.mozilla.org/integration/autoland/rev/49667216e3c2
Part 4: Add panel-footer-button class for panel-footer buttons in popupnotification. r=tgiles,desktop-theme-reviewers,dao
https://hg.mozilla.org/integration/autoland/rev/99dca8d67e20
Part 5: Add panel-footer-button class for buttons in protectionsPanel. r=mstriemer
https://hg.mozilla.org/integration/autoland/rev/ae7efa4f7ab4
Part 6: Remove unused selectors. r=hjones,desktop-theme-reviewers,dao

Comment 15

[Hanna Jones [:hjones]]

Landing the patches in this stack that are unaffected by the test failure. We're still working to resolve some issues with a test before landing the last piece of this work.

Comment 16

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/001ee53a42dc
https://hg.mozilla.org/mozilla-central/rev/8356d7123645
https://hg.mozilla.org/mozilla-central/rev/33d0d6f78d41
https://hg.mozilla.org/mozilla-central/rev/49667216e3c2
https://hg.mozilla.org/mozilla-central/rev/99dca8d67e20
https://hg.mozilla.org/mozilla-central/rev/ae7efa4f7ab4

Comment 17

[Cristian Tuns]

Backed out for causing a new regression (bug 1854699)

• Backout link

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/679865f37255
Part 6: Remove unused selectors. r=hjones,desktop-theme-reviewers,dao

Comment 19

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/679865f37255