1832378 - Refactor feature logic and don't require function references flag for enabling gc

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task, P3)

Comment 1

[Ryan Hunt [:rhunt]]

Attachment: Bug 1832378 - wasm: Refactor feature flags and let GC build in beta/release but remain disabled by-default. r?yury

This commit cleans up some of our feature logic.

• A WasmFeatures.h internal header is added for all this code
• The stage of a feature is turned into an enum, not a separate
  macro. This is generally easier to read.

As an improvement the concept of 'force enable flag' extension point
was added. This is used to enable the GC proposal even if the function
references proposal is not enabled.

This commit also lets wasm-gc/fr start building in beta/release. They
will remain off by default though (behind a pref).

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:rhunt, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a8e8ec667ea
wasm: Refactor feature flags and let GC build in beta/release but remain disabled by-default. r=yury

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8a8e8ec667ea