1832388 - Option to hide video overlay PiP button and keep the Url bar button

Status: NEW

(Toolkit :: Picture-in-Picture, enhancement, P3)

Description

[Almtst]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/114.0

Steps to reproduce:

Bug 1811318 introduced a PiP button on the Url bar, I find it redundant to have two buttons for the same action, so it makes sense to hide the video overlay button for a cleaner experience, but if you hide it, the Url bar button is also hidden, there should be a way to only hide the overlay button and keep the Url bar one.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Picture-in-Picture' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[jawexi7157]

Having 'media.videocontrols.picture-in-picture.video-toggle.enabled' set to false (and refreshing page) makes the address bar PIP icon not work even when forcibly made visible via userchrome.css. This seems like a clear oversight and a bug, so I'll hope too that this behavior is changed or fixed.

I believe 'media.videocontrols.picture-in-picture.urlbar-button.enabled' should be made to make the address bar icon appear no matter the setting of 'media.videocontrols.picture-in-picture.video-toggle.enabled' (which currently disables the function of both if set to false)

Comment 3

[jawexi7157]

Temporary workaround:

Enable PiP in Firefox settings

userContent.css

.pip-wrapper {
   display: none;
}

optionally for some styling add

userChrome.css

#picture-in-picture-button[hidden="true"] {
  display: inherit;
  opacity: 0.8;
}