1832391 - Phabricator feed process crashes when a revision is in draft status and setting approval-mozilla-* flag on the new attachment

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Phabricator Integration, defect)

Description

[David Lawrence [:dkl]]

{"Type":"Bugzilla.Extension.PhabBugz.Feed","Fields":{"msg":"REVISION CHANGE FOUND: D177656: Bug 1831223 - Added GeckoView Print Status | bug: 1831223 | ohall | ohall created D177656: Bug 1831223 - Added GeckoView 
Print Status.","type":"FEED"},"Severity":6,"EnvVersion":2.0,"Logger":"STDERR","Timestamp":1683751781000000000,"Hostname":"gha-bugzilla-phabbugz-6744948c9d-fsrrq","Pid":7}                                           
{"EnvVersion":2.0,"Severity":6,"Fields":{"msg":"Loading current policy: PHID-PLCY-n35ldkwdjbtxks64ldn5","type":"FEED"},"Type":"Bugzilla.Extension.PhabBugz.Feed","Logger":"STDERR","Timestamp":1683751781000000000,"P
id":7,"Hostname":"gha-bugzilla-phabbugz-6744948c9d-fsrrq"}                                                                                                                                                           
{"Timestamp":1683751782000000000,"Hostname":"gha-bugzilla-phabbugz-6744948c9d-fsrrq","Pid":7,"EnvVersion":2.0,"Type":"Bugzilla.Extension.PhabBugz.Feed","Severity":6,"Fields":{"msg":"Current policy projects: secure
-revision","type":"FEED"},"Logger":"STDERR"}                                                                                                                                                                         
{"Pid":7,"Hostname":"gha-bugzilla-phabbugz-6744948c9d-fsrrq","Timestamp":1683751782000000000,"Logger":"STDERR","Severity":6,"Fields":{"type":"FEED","msg":"Project groups do not match. Need new custom policy"},"Typ
e":"Bugzilla.Extension.PhabBugz.Feed","EnvVersion":2.0}                                                                                                                                                              
{"Hostname":"gha-bugzilla-phabbugz-6744948c9d-fsrrq","Pid":7,"Timestamp":1683751782000000000,"Logger":"STDERR","EnvVersion":2.0,"Type":"Bugzilla.Extension.PhabBugz.Feed","Severity":6,"Fields":{"type":"FEED","msg":
"Creating new custom policy: bmo-mobile-core-security"}}                                                                                                                                                             
{"Timestamp":1683751782000000000,"Hostname":"gha-bugzilla-phabbugz-6744948c9d-fsrrq","Pid":7,"Type":"Bugzilla.Extension.PhabBugz.Feed","Severity":6,"Fields":{"msg":"Checking for revision attachment","type":"FEED"}
,"EnvVersion":2.0,"Logger":"STDERR"}                                                                                                                                                                                 
{"Timestamp":1683751782000000000,"Pid":7,"Hostname":"gha-bugzilla-phabbugz-6744948c9d-fsrrq","EnvVersion":2.0,"Severity":6,"Fields":{"type":"FEED","msg":"Setting approval-mozilla-beta flag on revision attachment."
},"Type":"Bugzilla.Extension.PhabBugz.Util","Logger":"STDERR"}                                                                                                                                                       
{"Hostname":"gha-bugzilla-phabbugz-6744948c9d-fsrrq","Pid":7,"Timestamp":1683751782000000000,"Logger":"STDERR","EnvVersion":2.0,"Type":"Bugzilla.Extension.PhabBugz.Feed","Severity":6,"Fields":{"msg":"Attachment 93
32872 created or already exists.","type":"FEED"}}                                                                                                                                                                    
{"Timestamp":1683751782000000000,"Pid":7,"Hostname":"gha-bugzilla-phabbugz-6744948c9d-fsrrq","Severity":6,"Fields":{"type":"FEED","msg":"Updating obsolete status on attachmment 9332872"},"Type":"Bugzilla.Extension
.PhabBugz.Feed","EnvVersion":2.0,"Logger":"STDERR"}                                                                                                                                                                  
{"Pid":7,"Hostname":"gha-bugzilla-phabbugz-6744948c9d-fsrrq","Timestamp":1683751782000000000,"Logger":"STDERR","Fields":{"type":"FEED","msg":"Setting approval-mozilla-beta flag on revision attachment."},"Severity"
:6,"Type":"Bugzilla.Extension.PhabBugz.Util","EnvVersion":2.0}                                                                                                                                                       
Use of uninitialized value $status in concatenation (.) or string at /app/extensions/PhabBugz/lib/Util.pm line 64.                                                                                                   
{"Severity":6,"Fields":{"msg":"Set existing `approval-mozilla-beta` flag to ``.","type":"FEED"},"Type":"Bugzilla.Extension.PhabBugz.Util","EnvVersion":2.0,"Logger":"STDERR","Timestamp":1683751782000000000,"Pid":7,
"Hostname":"gha-bugzilla-phabbugz-6744948c9d-fsrrq"}                                                                                                                                                                 
Use of uninitialized value $status in string eq at Bugzilla/Flag.pm line 835.                                                                                                                                        
Use of uninitialized value $status in string eq at Bugzilla/Flag.pm line 835.                                                                                                                                        
Use of uninitialized value $status in string eq at Bugzilla/Flag.pm line 835.                                                                                                                                        
Use of uninitialized value $status in string eq at Bugzilla/Flag.pm line 835.                                                                                                                                        
{"Fields":{"vars":"{\"id\":2167086,\"status\":null}","msg":"The flag status for flag ID #2167086 is invalid.\n"},"Severity":0,"Type":"Bugzilla.Extension.PhabBugz.Feed","EnvVersion":2.0,"Logger":"STDERR","Timestamp
":1683751782000000000,"Pid":7,"Hostname":"gha-bugzilla-phabbugz-6744948c9d-fsrrq"}  

Comment 2

[BMO Github Automation]

Attachment: [mozilla-bteam/bmo] Bug 1832391 - Phabricator feed process crashes when a revision is in draft status and setting approval-mozilla-* flag on the new attachment (#2064)

Comment 3

[David Lawrence [:dkl]]

Merged
https://github.com/mozilla-bteam/bmo/commit/1969172636862da1aeb00ee6528d728f3bb6d117