1832481 - `cqh` is unexpectedly synced with other containers

Status: VERIFIED FIXED

(Core :: Layout, defect)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: index.html

Open the attachment and see the result.

Expected: The height of second gray line should be 2x larger than the first one (as the container is 2x larger) as in Chrome and Safari
Actual: Same height on Firefox

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Hi Emilio, is this something you can take a look or has there been a similar report? (I couldn't find one)

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1832481 - Clean up length handling. r=#style,#layout

No behavior change, but using Self is shorter and while I'm touching
this code might as well clean it up a little bit.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1832481 - Container units should prevent us from using the rule cache. r=#style,#layout

Much like with font-relative units, when they're used for a
non-inherited property we need to avoid using the rule cache.

This is because two elements matching the same rules won't get
guaranteed-equal non-inherited style structs.

Depends on D177732

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a6c9c215f51
Clean up length handling. r=dshin
https://hg.mozilla.org/integration/autoland/rev/710b5b1b445f
Container units should prevent us from using the rule cache. r=dshin

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/39964 for changes under testing/web-platform/tests

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/3a6c9c215f51
https://hg.mozilla.org/mozilla-central/rev/710b5b1b445f

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 8

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2023-05-10 Nightly build on Windows 10.
Verified as fixed on Firefox 115.0b4(build ID: 20230611180300) and Nightly 116.0a1(build ID: 20230612211509) on Windows 10, macOS 12, Ubuntu 22.