1832516 - Fix OpenPGP alias test involving mailnews/test/data/alias-9.json

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Kai Engert [:KaiE:]]

After bug 1829618 we have a new test failures.

The test expects that an exception is thrown when loading the file.

I see that in the past we got the following:

0:00.84 INFO "Running alias test with rules from: ../../../../../../mailnews/test/data/alias-9.json"
0:00.84 pid:390121 console.log: "exception when loading alias file openpgp-alias-rules.json : SyntaxError: JSON.parse: unexpected character at line 6 column 3 of the JSON data"

But after the prettier tweaked the file, we no longer get an exception.

Comment 1

[Kai Engert [:KaiE:]]

That JSON file was intentionally incorrect, to ensure that an incorrect input file results in the expected behavior.

I suggest to revert the change to that file, and exclude it from automatic prettier processing, is that possible?

Comment 2

[Kai Engert [:KaiE:]]

(In reply to Kai Engert (:KaiE:) from comment #0)

After bug 1829618 we have a new test failures.

Correction, it was bug 1831101 which made the change for Thunderbird.

Comment 3

[Kai Engert [:KaiE:]]

Attachment: Bug 1832516 - Don't run prettier on intentionally broken file mailnews/test/data/alias-9.json. r=john.bieling

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fbdb666555fa
Don't run prettier on intentionally broken file mailnews/test/data/alias-9.json. r=john.bieling