Closed Bug 1832516 Opened 11 months ago Closed 11 months ago

Fix OpenPGP alias test involving mailnews/test/data/alias-9.json

Categories

(MailNews Core :: Security: OpenPGP, defect)

defect

Tracking

(Not tracked)

RESOLVED FIXED
115 Branch

People

(Reporter: KaiE, Assigned: KaiE)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

After bug 1829618 we have a new test failures.

The test expects that an exception is thrown when loading the file.

I see that in the past we got the following:

0:00.84 INFO "Running alias test with rules from: ../../../../../../mailnews/test/data/alias-9.json"
0:00.84 pid:390121 console.log: "exception when loading alias file openpgp-alias-rules.json : SyntaxError: JSON.parse: unexpected character at line 6 column 3 of the JSON data"

But after the prettier tweaked the file, we no longer get an exception.

That JSON file was intentionally incorrect, to ensure that an incorrect input file results in the expected behavior.

I suggest to revert the change to that file, and exclude it from automatic prettier processing, is that possible?

Flags: needinfo?(standard8)

(In reply to Kai Engert (:KaiE:) from comment #0)

After bug 1829618 we have a new test failures.

Correction, it was bug 1831101 which made the change for Thunderbird.

Flags: needinfo?(standard8)
Keywords: regression
Regressed by: 1831101
Target Milestone: --- → 115 Branch

Pushed by john@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/fbdb666555fa
Don't run prettier on intentionally broken file mailnews/test/data/alias-9.json. r=john.bieling

Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: