1832519 - Don't show "Open in app" button

Status: RESOLVED FIXED

(Fenix :: General, enhancement, P1)

Comment 1

[Mr. Beedell, Roke Julian Lockhart]

Wouldn't this be a great opportunity instead to provide an "Open in app" menu which calls to the native Android API that shows all possible handlers for the file (of which Fenix would be registered) or is this already better handled by this occurring when no default is set, since that menu displays "Don't ask again"?

Comment 2

[Sylvestre Ledru [:Sylvestre]]

I am also curious to know what is the value of "Open in app" in general.
We are suggesting that our users should try other readers when, clearly, it is one of the best.

Comment 3

[Mr. Beedell, Roke Julian Lockhart]

https://bugzilla.mozilla.org/show_bug.cgi?id=1832519#c2

[e-mail], that's a very separate issue, and not one which I expect you to gain much support on. The whole reason for Firefox's existence is that it does not stifle competition, unlike its counterparts.

Comment 4

[Romain Testard [:RT]]

I was super confused by that button - I worry that it may end-up confusing more users than it will benefit.
There is a delicate trade off between enabling capabilities and confusing users, in this case I would argue that:

• It's likely a low frequency use case to open an already open PDF doc in another application
• If we see reasons for users to open a pdf in other apps from within Firefox then we should fix our feature gap or bugs. My understanding of what lead us to enable set to default is that we're pretty capable
• Users have fall-backs to do what's suggested here (copy and paste the URL, dowload and open in another app)

The current experience is broken (pressing the button does nothing but re-opening the pdf in a new tab) - let's fix it by removing the button if Firefox is set to default now. I'd suggest opening a separate bug for an "Open in app" menu if we feel strongly about it so it can be considered separately.

Comment 5

[Romain Testard [:RT]]

Actually removing the button in all instances even if Firefox is not set to default feels warranted following the same rationale as outlined above - can we please remove the button altogether?

Comment 6

[BMO Github Automation]

Attachment: [mozilla/pdf.js] [GeckoView] Remove the open-in-app button (bug 1832519) (#17771)

Comment 7

[miralobontiu]

Verified as implemented on the Fenix Nightly 125.0a1 from 3/18, and on Beta 125.0b2 with a Google Pixel 8 (Android 14), and a Samsung Galaxy A14 (Android 13).