Closed Bug 1832680 Opened 2 years ago Closed 2 years ago

Replace action buttons in about:logins with reusable CommandButton component

Categories

(Firefox :: about:logins, task)

Product:
Firefox
Component:
about:logins
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
117 Branch
Tracking Flags:
Tracking Status
firefox117 --- fixed

People

(Reporter: mtigley, Assigned: ssachdev)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxcm-productive-ux])

Attachments

(1 file, 3 obsolete files)

Bug 1832680 - Replaced action buttons in about:logins with reusable CommandButton component. r=#credential-management-reviewers!
48 bytes, text/x-phabricator-request
Details | Review

This issue is concerned with replacing all action buttons in about:logins with the new CommandButton component created in Bug 1810215.

This includes:

  • "Create new login" button
  • Edit button
  • Remove button
  • Copy button
Attachment #9338704 - Attachment is obsolete: true
Attachment #9338703 - Attachment description: WIP: Bug 1832680 - Replaced action buttons in about:logins with reusable CommandButton component. r=#credential-management-reviewers! → Bug 1832680 - Replaced action buttons in about:logins with reusable CommandButton component. r=#credential-management-reviewers!
Attachment #9338705 - Attachment is obsolete: true
Attachment #9341070 - Attachment is obsolete: true
Pushed by tgiles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6cbb422e23b5 Replaced action buttons in about:logins with reusable CommandButton component. r=mtigley,desktop-theme-reviewers,credential-management-reviewers,dao,tgiles

Backed out for causing failures on browser_preselect_login.js, browser_parsable_css.js

Backout link

Push with failures - bc6
Push with failures - bc2

Failure log - bc6
Failure log - bc2

Flags: needinfo?(ssachdev)
Pushed by ssachdev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c9fa25e405f7 Replaced action buttons in about:logins with reusable CommandButton component. r=mtigley,desktop-theme-reviewers,credential-management-reviewers,dao,tgiles

https://hg.mozilla.org/mozilla-central/rev/c9fa25e405f7

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox117: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
Flags: needinfo?(ssachdev)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: