Closed
Bug 1810215
Opened 1 year ago
Closed 8 months ago
Create a reusable CommandButton component
Categories
(Firefox :: about:logins, task, P2)
Firefox
about:logins
Tracking
()
RESOLVED
FIXED
117 Branch
Tracking | Status | |
---|---|---|
firefox117 | --- | fixed |
People
(Reporter: serg, Assigned: ssachdev)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxcm-productive-ux])
Attachments
(3 files)
No description provided.
Reporter | ||
Comment 1•1 year ago
|
||
Reporter | ||
Comment 2•1 year ago
|
||
I suspect that component eventually will be in more reusable area, but for now lets just focus on about:logins. We need a button with icon and text.
Reporter | ||
Updated•1 year ago
|
Assignee: nobody → mtigley
Severity: -- → N/A
Priority: -- → P2
Updated•1 year ago
|
Status: NEW → ASSIGNED
Updated•11 months ago
|
Status: ASSIGNED → NEW
Summary: Extract CommandButton → Create a reusable CommandButton component
Comment 3•11 months ago
•
|
||
Requirements
Renders
- An optional string describing the command it performs (Ex: “Edit”, “Remove”, etc…)
- An optional icon
- Optional tooltip for describing the action
Interactivity
Runs a callback that performs the desired action
Styling
See https://firefoxux.github.io/firefox-desktop-components/?path=/story/ui-widgets-button--regular-button. We should reuse this if possible.
Props
onClick
: <Function> The function to run when the button is clickedl10nId
: Optional <string> An l10n-id that translates to the rendered command stringicon
: Optional <string> The source URL of the icon to renderstate
: Optional <string> The state of the buttondisabled
: Optional <boolean> Whether or not the button is interactivetooltipText
: Optional <string> Tooltip text describing the action of the button
Updated•11 months ago
|
Assignee: mtigley → ssachdev
Status: NEW → ASSIGNED
Assignee | ||
Updated•11 months ago
|
Assignee | ||
Updated•11 months ago
|
Whiteboard: [fxcm-productive-ux]
Assignee | ||
Comment 4•10 months ago
|
||
Depends on D178056
Assignee | ||
Comment 5•10 months ago
|
||
Depends on D179258
Pushed by tgiles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9636cc512a42 Created a reusable CommandButton component. r=credential-management-reviewers,sgalich,tgiles,mtigley,desktop-theme-reviewers,dao
Pushed by tgiles@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fcb2279fe728 Added a story file for the reusable CommandButton component. r=credential-management-reviewers,mtigley
Comment 8•8 months ago
|
||
Backed out for causing failures on browser_preselect_login.js, browser_parsable_css.js
Flags: needinfo?(ssachdev)
Pushed by ssachdev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8d82e862c269 Created a reusable CommandButton component. r=credential-management-reviewers,sgalich,tgiles,mtigley,desktop-theme-reviewers,dao
Comment 10•8 months ago
|
||
Pushed by ssachdev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/09826d4eb13b Added a story file for the reusable CommandButton component. r=credential-management-reviewers,mtigley
Comment 11•8 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8d82e862c269
https://hg.mozilla.org/mozilla-central/rev/09826d4eb13b
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
status-firefox117:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
Assignee | ||
Updated•8 months ago
|
Flags: needinfo?(ssachdev)
You need to log in
before you can comment on or make changes to this bug.
Description
•