1832704 - Remove SearchService's init-complete, replace by a promise that resolves or rejects as appropraite

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mandy Cheang [:mcheang][she/her]]

We send the "init-complete" notification regardless if SearchService initialization has failed or succeeded. Instead, we should send "init-failed" notification when SearchService has failed.

We are sending "init-complete" notification in SearchService.#init here

Extension System waits for "init-complete" here.

First, we need to create the "init-failed" notification by calling notifyObservers. Then, there needs to be further investigation on how external callers will handle the new "init-failed" notification.

Comment 1

[Mark Banner (:standard8)]

We took a look at this and decided that it would be better to remove the "init-complete" notification. Instead, we can add a promiseInitialized property that will resolve when the search service has successfully initialized, or reject if it has failed. Note, that this will not trigger initialization, unlike calling init().

This should be clearer and easier that trying to observe notifications and handling them appropriately. It also means that logic for detecting when the search service has finished initialising is all contained within the search service.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1832704 - Remove SearchService's init-complete, replace by a promise that resolves or rejects as appropriate. r?mcheang!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0a2aa2ffe6d
Remove SearchService's init-complete, replace by a promise that resolves or rejects as appropriate. r=mcheang,extension-reviewers,robwu

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures on toolkit/components/search/tests/xpcshell/test_async.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/143c7ec76d2c7d587160128f03b96f88831a450e

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/components/search/tests/xpcshell/test_async.js | test_async - [test_async : 1] Unexpected console message received during test

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6b3f678da8b
Remove SearchService's init-complete, replace by a promise that resolves or rejects as appropriate. r=mcheang,extension-reviewers,robwu

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b6b3f678da8b