1849924 - Remove unnecessary init-complete observers from search bar and search one-offs code

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

We have some unnecessary init-complete observers in the search code:

• searchbar.js listens for init-complete, when it is already awaiting the result of Services.search.init.
• SearchOneOffs.js waits for init-complete and clears the cache, however, it cannot fill the cache until the initialisation is complete. Even if it did, then waiting for init-complete could clear this._engineInfo before getEngineInfo has finished, hence potentially causing issues.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1849924 - Remove unnecessary init-complete observers from search bar and search one-offs code. r?#search-reviewers!

Depends on D186737

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4612dab41dd
Remove unnecessary init-complete observers from search bar and search one-offs code. r=search-reviewers,mcheang

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e4612dab41dd