1833042 - Customize unified toolbar does not offer `Save` when only changing button style

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect, P3)

Description

[Wayne Mery (:wsmwk)]

Both beta and daily

Comment 1

[Ikey Doherty]

Findings: Currently the button style is applied immediately and doesn't need saving.
It is theoretically possible to make this deferred, however it would mean changing the other code to ensure that it was rendered
using the temporary setting, not the globally saved setting.

Comment 2

[Alessandro Castellani [:aleca]]

Indeed we should allow users to only see the preview of the button style when it changes but require a "Save" action to apply that state.
This will require a little bit more work since historically that button style dropdown always live reloaded the toolbar buttons.
I'm setting P3 because this is nice to have but definitely not a blocker and not a big issue since it doesn't cause dataloss or any unwanted states that can't get easily changed.

Comment 4

[Ikey Doherty]

What do we want done with this?

Comment 5

[Alessandro Castellani [:aleca]]

We should not automatically update the pref and enable the Save button when something changes.
We can give the user a preview of the final result by simply applying the needed classes to the preview target, like we do here but without passing through the pref change.https://searchfox.org/comm-central/rev/1924a0c102a4d3a75af572a16336e4b8056d0d3f/mail/components/unifiedtoolbar/content/unified-toolbar-customization-pane.mjs#32-46

We save the pref only if the user clicks "Save", which means we need to rework this in order to set the pref based on the selected menuitem value, and not doing it automatically every time something changes. https://searchfox.org/comm-central/rev/1924a0c102a4d3a75af572a16336e4b8056d0d3f/mail/components/unifiedtoolbar/content/unified-toolbar-customization.mjs#119-124

Comment 6

[Anje]

I discovered the 'Customise' option is not a separate window, it consumes the entire Thunderbird window whilst at the same minute obliterating any instant visual reference to the fact that it is not a separate window.

Unfortunately, I view the window and then want to close it, so my auto action is to click on the top right X which is what anyone does when they want to close the window.
Now I've exited Thunderbird and that was not desired. Having done it a couple of times, I'm not a happy bunny. So it's likely others will do the same by accident.

Can something be done to stop the visual effect of the 'Customise Toolbars' window looking like a completely separate window as the natural reflex is to use the top right X.
Suggestion:
Either it operates like the 'Config Editor' - 'Advanced Preferences' and opens in a new tab, so you can still see Thunderbird tabs etc.
OR it really is a separate window and operates like it the toolbar 'customise' option in version 102* kept within the confines of the Thunderbird window, but it has it's own top right X.

Regarding the 'Save' button.
I'm not so sure there is a reason for the 'Save' button to be disabled at any point in time.
Keep it simple.

Comment 7

[Alessandro Castellani [:aleca]]

Kindly snatching this because I have a quick fix patch for it.

Comment 8

[Alessandro Castellani [:aleca]]

Attachment: Bug 1833042 - Don't automatically update the button style preference when changed in the unified toolbar customization panel. r=freaktechnik,rjl

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bffd5287557a
Don't automatically update the button style preference when changed in the unified toolbar customization panel. r=freaktechnik

Comment 10

[Alessandro Castellani [:aleca]]

Comment on attachment 9340409 [details]
Bug 1833042 - Don't automatically update the button style preference when changed in the unified toolbar customization panel. r=freaktechnik,rjl

[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined: Slight confusion when changing the button style in the new unified toolbar customization view
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 11

[Wayne Mery (:wsmwk)]

Comment on attachment 9340409 [details]
Bug 1833042 - Don't automatically update the button style preference when changed in the unified toolbar customization panel. r=freaktechnik,rjl

[Triage Comment]
Approved for beta

Comment 12

[Daniel Darnell [:dandarnell]]

Thunderbird 115.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/80168f36c147