1833091 - Replace direct UrlbarInput.inputField access with UrlbarInput proxies

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement)

Comment 1

[Marc Seibert (:mseibert)]

Attachment: WIP: Bug 1833091 - Adding LRM to URL when http:// trimmed

Depends on D176529

Comment 2

[Marc Seibert (:mseibert)]

Attachment: Bug 1833091 - Replacing UrlbarInput inputField.value with .value.r=dao

Comment 3

[Marc Seibert (:mseibert)]

Attachment: Bug 1833091 - Replacing all get refs of UrlbarInput 'inputField.value' with '.value'.r=dao

Comment 4

[Phabricator Automation]

Comment on attachment 9333588 [details]
WIP: Bug 1833091 - Adding LRM to URL when http:// trimmed

Revision D178018 was moved to bug 1836962. Setting attachment 9333588 [details] to obsolete.

Comment 5

[Marc Seibert (:mseibert)]

Attachment: Bug 1833091 - Replacing all set refs of UrlbarInput 'inputField.value' [deprecated]

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/862bd1ab18fd
Replacing all get refs of UrlbarInput 'inputField.value' with '.value'.r=dao

Comment 7

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failure on browser_ext_webNavigation_urlbar_transitions.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/16d25f87fedb675005f308c0bb9fa8796c5a48fa
Log link: https://treeherder.mozilla.org/logviewer?job_id=418299437&repo=autoland&lineNumber=37949

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e44f4d43b823
Replacing all get refs of UrlbarInput 'inputField.value' with '.value'.r=dao

Comment 9

[Marc Seibert (:mseibert)]

Attachment: Bug 1833091 - Replacing all set refs of UrlbarInput 'inputField.value'.r=dao

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e44f4d43b823

Comment 11

[Natalia Csoregi [:nataliaCs]]

Backed out for causing permafailures on browser_topsites_annotation.js

• backout: https://hg.mozilla.org/integration/autoland/rev/8676cb5ae56b68f2978f3077163c1aee6deda801
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=estT6x3LSimj0wJaU77ipg.0&revision=e44f4d43b823c920e7b74842d2aab66cb7c9ae9a
• failure log: https://treeherder.mozilla.org/logviewer?job_id=418491579&repo=autoland&lineNumber=5862

[task 2023-06-07T23:55:26.047Z] 23:55:26     INFO - TEST-PASS | browser/components/newtab/test/browser/browser_topsites_annotation.js | The triggeringPlaceId in database is correct for https://example.com/ - 1 == 1 - 
[task 2023-06-07T23:55:26.048Z] 23:55:26     INFO - Buffered messages finished
[task 2023-06-07T23:55:26.051Z] 23:55:26     INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_topsites_annotation.js | A promise chain failed to handle a rejection: can't access property "exists", file is null - stack: AddonsList@resource://testing-common/AddonTestUtils.sys.mjs:123:9
[task 2023-06-07T23:55:26.051Z] 23:55:26     INFO - loadAddonsList@resource://testing-common/AddonTestUtils.sys.mjs:923:23
[task 2023-06-07T23:55:26.054Z] 23:55:26     INFO - async*promiseStartupManager@resource://testing-common/AddonTestUtils.sys.mjs:783:16
[task 2023-06-07T23:55:26.054Z] 23:55:26     INFO - async*initXPCShellDependencies@resource://testing-common/UrlbarTestUtils.sys.mjs:1175:33
[task 2023-06-07T23:55:26.054Z] 23:55:26     INFO - init@resource://testing-common/UrlbarTestUtils.sys.mjs:76:12
[task 2023-06-07T23:55:26.054Z] 23:55:26     INFO - @chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_topsites_annotation.js:24:10
[task 2023-06-07T23:55:26.054Z] 23:55:26     INFO - inherit/<@chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_topsites_annotation.js:776:5
[task 2023-06-07T23:55:26.054Z] 23:55:26     INFO - async*withNewTab@resource://testing-common/BrowserTestUtils.sys.mjs:149:22
[task 2023-06-07T23:55:26.054Z] 23:55:26     INFO - async*inherit@chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_topsites_annotation.js:629:26
[task 2023-06-07T23:55:26.054Z] 23:55:26     INFO - handleTask@chrome://mochikit/content/browser-test.js:1131:26
[task 2023-06-07T23:55:26.054Z] 23:55:26     INFO - _runTaskBasedTest@chrome://mochikit/content/browser-test.js:1203:18
[task 2023-06-07T23:55:26.054Z] 23:55:26     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1345:14
[task 2023-06-07T23:55:26.054Z] 23:55:26     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1120:14
[task 2023-06-07T23:55:26.054Z] 23:55:26     INFO - SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13
[task 2023-06-07T23:55:26.054Z] 23:55:26     INFO - Rejection date: Wed Jun 07 2023 23:55:25 GMT+0000 (Coordinated Universal Time) - false == true - {"filename":"resource://testing-common/PromiseTestUtils.sys.mjs","name":"assertNoUncaughtRejections","sourceId":575,"lineNumber":266,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/browser-test.js","name":"handleTask","sourceId":541,"lineNumber":1159,"columnNumber":22,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome://mochikit/content/browser-test.js","name":"_runTaskBasedTest","sourceId":541,"lineNumber":1203,"columnNumber":18,"sourceLine":"","asyncCause":null,"asyncCaller":{"filename":"chrome://mochikit/content/browser-test.js","name":"Tester_execTest","sourceId":541,"lineNumber":1345,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/browser-test.js","name":"nextTest/<","sourceId":541,"lineNumber":1120,"columnNumber":14,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochikit/content/tests/SimpleTest/SimpleTest.js","name":"SimpleTest.waitForFocus/<","sourceId":566,"lineNumber":1056,"columnNumber":13,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":null,"formattedStack":"SimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13\n","nativeSavedFrame":{}},"formattedStack":"nextTest/<@chrome://mochikit/content/browser-test.js:1120:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13\n","nativeSavedFrame":{}},"formattedStack":"async*Tester_execTest@chrome://mochikit/content/browser-test.js:1345:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1120:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13\n","nativeSavedFrame":{}},"caller":null,"formattedStack":"async*_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1203:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1345:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1120:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13\n","nativeSavedFrame":{}},"caller":null,"formattedStack":"handleTask@chrome://mochikit/content/browser-test.js:1159:22\nasync*_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1203:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1345:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1120:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13\n","nativeSavedFrame":{}},"formattedStack":"assertNoUncaughtRejections@resource://testing-common/PromiseTestUtils.sys.mjs:266:14\nhandleTask@chrome://mochikit/content/browser-test.js:1159:22\nasync*_runTaskBasedTest@chrome://mochikit/content/browser-test.js:1203:18\nasync*Tester_execTest@chrome://mochikit/content/browser-test.js:1345:14\nnextTest/<@chrome://mochikit/content/browser-test.js:1120:14\nSimpleTest.waitForFocus/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1056:13\n","nativeSavedFrame":{}}
[task 2023-06-07T23:55:26.054Z] 23:55:26     INFO - Stack trace:
[task 2023-06-07T23:55:26.054Z] 23:55:26     INFO - resource://testing-common/PromiseTestUtils.sys.mjs:assertNoUncaughtRejections:266
[task 2023-06-07T23:55:26.054Z] 23:55:26     INFO - chrome://mochikit/content/browser-test.js:handleTask:1159
[task 2023-06-07T23:55:26.055Z] 23:55:26     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1203
[task 2023-06-07T23:55:26.055Z] 23:55:26     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1345
[task 2023-06-07T23:55:26.055Z] 23:55:26     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1120
[task 2023-06-07T23:55:26.055Z] 23:55:26     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1056
[task 2023-06-07T23:55:26.055Z] 23:55:26     INFO - Leaving test bound inherit
[task 2023-06-07T23:55:26.056Z] 23:55:26     INFO - Entering test bound timeout
[task 2023-06-07T23:55:26.174Z] 23:55:26     INFO - GECKO(9712) | console.error: "Failed to fetch https://spocs.getpocket.com/user: Not one of allowed prefixes (data:)"
[task 2023-06-07T23:55:26.179Z] 23:55:26     INFO - Open the tile
[task 2023-06-07T23:55:26.299Z] 23:55:26     INFO - Open specific link by type and wait for loading.
[task 2023-06-07T23:55:26.362Z] 23:55:26     INFO - Console message: [JavaScript Warning: "This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use <!DOCTYPE html>." {file: "https://example.com/browser/browser/components/newtab/test/browser/annotation_first.html" line: 0}]
[task 2023-06-07T23:55:26.389Z] 23:55:26     INFO - Check database for the destination.
[task 2023-06-07T23:55:26.392Z] 23:55:26     INFO - TEST-PASS | browser/components/newtab/test/browser/browser_topsites_annotation.js | Frecency is correct - -1 == -1 - 

Comment 12

[Iulian Moraru]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/eb8c0d85087f

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6346eb3965bd
Replacing all get refs of UrlbarInput 'inputField.value' with '.value'.r=mak

Comment 14

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6346eb3965bd

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9af112f1bea
Replacing all set refs of UrlbarInput 'inputField.value'.r=dao

Comment 16

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d9af112f1bea