Only trim URL if directionality doesn't change to RTL
Categories
(Firefox :: Address Bar, enhancement)
Tracking
()
People
(Reporter: dao, Assigned: mseibert)
References
(Blocks 1 open bug)
Details
(Whiteboard: [snt])
Attachments
(2 files, 5 obsolete files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
dmeehan
:
approval-mozilla-esr115+
|
Details | Review |
+++ This bug was initially created as a clone of Bug #1833091 +++
Updated•2 years ago
|
| Assignee | ||
Comment 1•2 years ago
|
||
Depends on D176529
| Assignee | ||
Updated•2 years ago
|
| Assignee | ||
Comment 2•2 years ago
|
||
Updated•2 years ago
|
| Assignee | ||
Comment 3•2 years ago
|
||
Updated•2 years ago
|
Updated•2 years ago
|
| Assignee | ||
Updated•2 years ago
|
| Assignee | ||
Comment 4•2 years ago
|
||
| Assignee | ||
Comment 5•2 years ago
|
||
Updated•2 years ago
|
| Reporter | ||
Updated•2 years ago
|
Updated•2 years ago
|
Comment 7•2 years ago
|
||
| bugherder | ||
Comment 8•2 years ago
|
||
Marc, it may be interesting to uplift this to ESR 115, could you check how complicate that uplift would be?
Updated•2 years ago
|
| Assignee | ||
Comment 9•2 years ago
|
||
Updated•2 years ago
|
| Assignee | ||
Comment 10•2 years ago
|
||
Updated•2 years ago
|
| Comment hidden (obsolete) |
Comment 12•2 years ago
|
||
Uplift Approval Request
- Is Android affected?: no
- Needs manual QE test: yes
- Risk associated with taking this patch: low/medium
- Fix verified in Nightly: no
- Explanation of risk level: This only affects URLs with RTL parts
- String changes made/needed: None
- Steps to reproduce for manual QE testing: Enter a URL with RTL characters. Example: "http://"اختبار.اختبار/www.mozilla.org/index.html". In this case http shouldn't be trimmed.
- User impact if declined: URLs with RTL domains may appear incorrectly formatted.
- Code covered by automated testing: yes
| Assignee | ||
Updated•2 years ago
|
| Assignee | ||
Updated•2 years ago
|
Comment 13•2 years ago
|
||
No reason to reopen the bug for uplifts.
Comment 14•2 years ago
|
||
Comment on attachment 9356811 [details]
Bug 1836962 - Only trim URL if directionality doesn't change to RTL.
Approved for 115.4esr.
Comment 15•2 years ago
|
||
| uplift | ||
Updated•2 years ago
|
Updated•2 years ago
|
Comment 16•2 years ago
|
||
I'm having difficulties understanding how exactly we should verify this bug.
I entered in the address bar the url provided in previous comments "http://"اختبار.اختبار/www.mozilla.org/index.html" and get redirected to google search page and I can't see any differences of the URL comparing the latest NIghtly and an older one.
Could you please provide some advice on how should we verify this bug?
Thanks.
Comment 17•2 years ago
•
|
||
(In reply to Hani Yacoub, Desktop QA from comment #16)
I entered in the address bar the url provided in previous comments "http://"اختبار.اختبار/www.mozilla.org/index.html" and get redirected to google
There's an unexpected " character in that string
| Assignee | ||
Comment 18•2 years ago
|
||
Yes, I am sorry. I put the '"' in there by accident.
Comment 19•2 years ago
|
||
Verified as fixed on Firefox Nightly 120.0a1 (2023-10-09) and on Firefox 115.4.0esr (treeherder) on Windows 10 x64, Windows 11 x64 and on Ubuntu 20.04.
Description
•