Closed Bug 1836962 Opened 2 years ago Closed 2 years ago

Only trim URL if directionality doesn't change to RTL

Categories

(Firefox :: Address Bar, enhancement)

enhancement

Tracking

()

VERIFIED FIXED
117 Branch
Tracking Status
firefox-esr115 --- verified
firefox117 --- verified

People

(Reporter: dao, Assigned: mseibert)

References

(Blocks 1 open bug)

Details

(Whiteboard: [snt])

Attachments

(2 files, 5 obsolete files)

+++ This bug was initially created as a clone of Bug #1833091 +++

Depends on D176529

Assignee: nobody → mseibert
Attachment #9337669 - Attachment is obsolete: true
Attachment #9340300 - Attachment is obsolete: true
Attachment #9342723 - Attachment description: WIP: Bug 1836962 - Add LRM to URL when http:// trimmed → Bug 1836962 - Add LRM to URL when http:// trimmed.r=dao
Status: NEW → ASSIGNED
Attachment #9345886 - Attachment is obsolete: true
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/563622404392 Only trim URL if directionality doesn't change to RTL.r=dao
Blocks: 1845710
Summary: Add LRM to URL when http:// trimmed → Only trim URL if directionality doesn't change to RTL
Attachment #9342723 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch

Marc, it may be interesting to uplift this to ESR 115, could you check how complicate that uplift would be?

Flags: needinfo?(mseibert)
Attachment #9356793 - Attachment is obsolete: true
Attachment #9356811 - Flags: approval-mozilla-esr115?

Uplift Approval Request

  • Is Android affected?: no
  • Needs manual QE test: yes
  • Risk associated with taking this patch: low/medium
  • Fix verified in Nightly: no
  • Explanation of risk level: This only affects URLs with RTL parts
  • String changes made/needed: None
  • Steps to reproduce for manual QE testing: Enter a URL with RTL characters. Example: "http://"اختبار.اختبار/www.mozilla.org/index.html". In this case http shouldn't be trimmed.
  • User impact if declined: URLs with RTL domains may appear incorrectly formatted.
  • Code covered by automated testing: yes
Flags: needinfo?(mseibert)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

No reason to reopen the bug for uplifts.

Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED

Comment on attachment 9356811 [details]
Bug 1836962 - Only trim URL if directionality doesn't change to RTL.

Approved for 115.4esr.

Attachment #9356811 - Flags: approval-mozilla-esr115? → approval-mozilla-esr115+
QA Whiteboard: [qa-triaged]

I'm having difficulties understanding how exactly we should verify this bug.
I entered in the address bar the url provided in previous comments "http://"اختبار.اختبار/www.mozilla.org/index.html" and get redirected to google search page and I can't see any differences of the URL comparing the latest NIghtly and an older one.

Could you please provide some advice on how should we verify this bug?
Thanks.

Flags: needinfo?(mseibert)

(In reply to Hani Yacoub, Desktop QA from comment #16)

I entered in the address bar the url provided in previous comments "http://"اختبار.اختبار/www.mozilla.org/index.html" and get redirected to google

There's an unexpected " character in that string

Yes, I am sorry. I put the '"' in there by accident.

Flags: needinfo?(mseibert)

Verified as fixed on Firefox Nightly 120.0a1 (2023-10-09) and on Firefox 115.4.0esr (treeherder) on Windows 10 x64, Windows 11 x64 and on Ubuntu 20.04.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: