1833471 - Implement :first for @page rules

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emily McDonough [:alaskanemily]]

With our current support for named pages, :first will both be the simplest page pseudo-class to implement, and will be immediately useful for existing code.

Comment 1

[Emily McDonough [:alaskanemily]]

Attachment: Bug 1833471 Part 1 - Implement @page pseudo-class parsing and rule handling

This currently will not match page-rules based on any selectors with any
pseudo-classes present.

Comment 2

[Emily McDonough [:alaskanemily]]

Attachment: Bug 1833471 Part 2 - Export @page pseudo-class flags to Gecko style code

Comment 3

[Emily McDonough [:alaskanemily]]

Attachment: Bug 1833471 Part 3 - Add :first page pseudo-class tests.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16164bf63457
Part 1 - Implement @page pseudo-class parsing and rule handling r=emilio
https://hg.mozilla.org/integration/autoland/rev/e21e18f3f729
Part 2 - Export @page pseudo-class flags to Gecko style code r=emilio
https://hg.mozilla.org/integration/autoland/rev/547eef705668
Part 3 - Add :first page pseudo-class tests. r=emilio

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40661 for changes under testing/web-platform/tests

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for wpt failure on page-rule-declarations-000.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/1fa9fd10adfa7f4246e4c75d8c26458900028488
Log link: https://treeherder.mozilla.org/logviewer?job_id=420113599&repo=autoland&lineNumber=5405

Please also check https://treeherder.mozilla.org/logviewer?job_id=420116919&repo=autoland&lineNumber=5646

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 8

[Emily McDonough [:alaskanemily]]

Just a note about why it looks like more tests are failing in WPT css/css-page/page-rule-declarations-000.html, the last expected failure of [CSS Paged Media: parsing @page declarations] indicates some page rules could not be parsed. Before this patch, the two new expected-fails were covered by that annotation because they included :first and :right.

We fail them now because we don't support the properties, but they show up as distinct failures because we can parse the selectors.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd4e99d77a6b
Part 1 - Implement @page pseudo-class parsing and rule handling r=emilio
https://hg.mozilla.org/integration/autoland/rev/e76595d749fb
Part 2 - Export @page pseudo-class flags to Gecko style code r=emilio
https://hg.mozilla.org/integration/autoland/rev/69c9504ac848
Part 3 - Add :first page pseudo-class tests. r=emilio

Comment 10

[Norisz Fay [:noriszfay]]

Backed out for causing failures on cssom-ruleTypeAndOrder.html, page-rule-declarations-000.html

Backout link

Push with failures

Failure log

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c48fab5fd55f
Part 1 - Implement @page pseudo-class parsing and rule handling r=emilio
https://hg.mozilla.org/integration/autoland/rev/52272706d0b0
Part 2 - Export @page pseudo-class flags to Gecko style code r=emilio
https://hg.mozilla.org/integration/autoland/rev/47085465184b
Part 3 - Add :first page pseudo-class tests. r=emilio

Comment 13

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c48fab5fd55f
https://hg.mozilla.org/mozilla-central/rev/52272706d0b0
https://hg.mozilla.org/mozilla-central/rev/47085465184b

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot