[wpt-sync] Sync PR 40047 - Reland "Improve hover triggering functionality to support popover=manual"
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox115 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
(Blocks 1 open bug, Regressed 1 open bug, )
Details
(Whiteboard: [wptsync downstream])
Attachments
(1 file)
912.77 KB,
text/plain
|
Details |
Sync web-platform-tests PR 40047 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/40047
Details from upstream follow.
Mason Freed <masonf@chromium.org> wrote:
Reland "Improve hover triggering functionality to support popover=manual"
This is a reland of commit e4cde2ad20aac0ace162db28090bc421df2e7e76
The compile failure was caused by a collision with this CL:
https://chromium.googlesource.com/chromium/src/+/3bb3e58b8a4c27b2c39b13a5ee0488a83310b725I updated the base::EnumSet constructor usage accordingly.
Original change's description:
Improve hover triggering functionality to support popover=manual
This CL primarily adds a much larger hover hiding test, which tests
all popover types, two invoker types, and all popovertargetaction
values. In building that, I found a number of cases that weren't
properly handled, mostly because hover detection was using a version
of IsNodePopoverDescendant that was fairly manual and old. This
new version makes better use of a newly-expanded
FindTopmostRelatedPopover which is able to optionally look at manual
popovers. In doing this, I also refactored theinclusive
argument
into an EnumSet to allow controlling the manual popover behavior
at the same time.Bug: 1416284
Fixed: 1443372
Fixed: 1445580
Change-Id: I2370610b4c7517fa635c353f0cfaf6de7b16b3af
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4505324
Commit-Queue: Mason Freed \<masonf@chromium.org>
Auto-Submit: Mason Freed \<masonf@chromium.org>
Reviewed-by: Joey Arhar \<jarhar@chromium.org>
Commit-Queue: Joey Arhar \<jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1144968}Bug: 1416284
Change-Id: I8d5873d4a5bd3b7949a3bf5ffaf770dc4001f34b
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/4540498
WPT-Export-Revision: 2e263e2089c97abdfa11d11350f792076f7a9b84
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
Assignee | ||
Comment 2•2 years ago
|
||
Comment 4•1 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a1669031a977
https://hg.mozilla.org/mozilla-central/rev/a04bb5a9d0a8
Description
•