1833613 - [US][grubhub] The second row of the street address is autofilled in both street address fields

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect)

Description

[Alin Ilea, Desktop QA]

Attachment: 2023-05-17_13h30_21.mp4

Found in

• Nightly 115.0a1

Affected versions

• Nightly 115.0a1
• Beta 114.0b4
• Release 113

Tested platforms

• Affected platforms: Windows 10, macOS 12, Ubuntu 20.04

Preconditions

• Set browser.search.region to US in about:config
• Have an already saved address in about:preferences. Make sure the street address is filled on 2 rows.

Steps to reproduce

1. Go to https://www.grubhub.com
2. Go to Account > Saved > Add new address
3. Click on any field and select the address(saved in preconditions) from the dropdown.

Expected result

• The first line of the saved address should be autofilled in the street address field and the second line should be autofilled only in the Apt,suite,floor field.

Actual result

• The second line of the saved street address is autofilled in both fields (street address and Apt,suite,floor).

Regression range

• Not a recent regression.

Additional notes

• The issue is NOT reproducible in Chrome.

Comment 1

[Alin Ilea, Desktop QA]

Attachment: www.grubhub.com.html

Fathomfox downloaded sample

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:ailea, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 3

[Dimi Lee [:dimi]]

Attachment: Bug 1833613 - Implement heuristic to interpret `street-address` as `address-line1` r=#credential-management-reviewers

A new heuristic has been introduced that interprets "street-address" as "address-line1".
This is triggered when "address-line2" is detected, and the field preceding "address-line2" is "street-address".

This modification addresses an issue with certain websites incorrectly utilizing
"street-address" in place of "address-line1".

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc24f93612da
Implement heuristic to interpret `street-address` as `address-line1` r=credential-management-reviewers,sgalich

Comment 5

[Cosmin Sabou [:CosminS]]

Backed out for xpcshell failures on test_collectFormFields.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&fromchange=ee5fc34ecac46f6c506ad928c8a518abfc640ba0&searchStr=xpc&test_paths=browser%2Fextensions%2Fformautofill%2Ftest%2Funit&tochange=0a8e469885812e658c1c703bdbf10772e7a0d610&selectedTaskRun=ERlAZ08ITH27mLUNSDK0sw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=416849472&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/0a8e469885812e658c1c703bdbf10772e7a0d610

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31394a5dd306
Implement heuristic to interpret `street-address` as `address-line1` r=credential-management-reviewers,sgalich

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/31394a5dd306

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dimi, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox114 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Alin Ilea, Desktop QA]

Verified - Fixed in latest Nightly 115.0a1 (2023-05-25). The second line of the saved street address is now autofilled accordingly only in the "Apt,suite,floor" field.