1833891 - Worker module tests for construction with a file URL fail

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect, P2)

Description

[Jon Coppeard (:jonco)]

The following two WPTs are failing:

/workers/modules/dedicated-worker-import-failure.html
 - Worker construction for a file URL should throw an exception.
/workers/modules/shared-worker-import-failure.html
 - SharedWorker construction for a file URL should throw an exception.

The test expect new Worker to synchronously throw a SecurityError when attempting to start a module worker with a file: URL.

I checked our implmentation and the worker does fail to start but a synchronous error is not thrown.

Looking at the spec I'm not sure this is required:

https://html.spec.whatwg.org/#dom-worker

Regardless we may want to make this throw synchronously in this case anyway since modules are always fetched using CORS which precludes the use of file: URLs.

Comment 1

[Eden Chuang[:edenchuang]]

Hi Yoshi, could you help take a look at this?

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Bug 1833891 - Update the WPT test for error handling behavior when worker loading a cross-origin script.

When worker is trying to load some cross-origin script, the error
handling is not consistent accross all browsers,
see https://github.com/web-platform-tests/wpt/pull/13671

So this patch references the test "/workers/Worker_cross_origin_security_err.htm"
and updates the test to make it pass on Firefox.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73259a567a07
Update the WPT test for error handling behavior when worker loading a cross-origin script. r=dom-worker-reviewers,smaug,zcorpan

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/40496 for changes under testing/web-platform/tests

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/73259a567a07

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/75b0d9794bd8