1833913 - Add default text to info section in about:privatebrowsing

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P2)

Description

[Punam Dahiya [:pdahiya]]

Scope of this bug is to look into adding default string to info section of PBM mode that ends up showing blank when ASRouter has delay in loading promo and info messages

https://searchfox.org/mozilla-central/rev/2ca95198a2a0806de358a0484d96d4354e3cbaab/browser/components/privatebrowsing/content/aboutPrivateBrowsing.html#56

https://searchfox.org/mozilla-central/rev/2ca95198a2a0806de358a0484d96d4354e3cbaab/browser/components/privatebrowsing/content/aboutPrivateBrowsing.js#244

https://searchfox.org/mozilla-central/rev/2ca95198a2a0806de358a0484d96d4354e3cbaab/browser/components/newtab/lib/OnboardingMessageProvider.jsm#833

Comment 1

[Shane Hughes [:aminomancer]]

Attachment: Bug 1833913 - Add default private newtab content. r=#omc-reviewers,pdahiya

Synchronously render default info content on about:privatebrowsing while
waiting for ASRouter to handle messages. Update the script and
stylesheet to account for rendering happening twice now. Add a browser
test to verify the content is rendered while ASRouter is hanging.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:aminomancer, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ce9449255f9
Add default private newtab content. r=pdahiya,omc-reviewers,desktop-theme-reviewers,sfoster

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing mochitest failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/d12d77f2c40b11c07d35615ce6d200fc9e062d60

Push with failures

Failure log -> mochitest

Failure log -> TV

Comment 5

[Shane Hughes [:aminomancer]]

Pretty sure that is bug 1775956. I have a patch up to fix the intermittent. I'll try landing it first.

Comment 6

[Sam Foster [:sfoster] (he/him)]

Clearing need-info, looks like :aminomancer is actively tracking this.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f4b944fb41a
Add default private newtab content. r=pdahiya,omc-reviewers,desktop-theme-reviewers,sfoster

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5f4b944fb41a