1834361 - scale() does not serialize NaN/infinity numbers correctly

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, defect)

Description

[Oliver Medhurst [:canadahonk]]

scale(calc(...)) does not serialize NaN/infinity outcomes correctly. This breaks a few NaN/inf WPT subtests (not specific for scale(), just general tests). Needs more investigation.

WPT tests:

• See end of subtests here exclusively failing with us: https://wpt.fyi/results/css/css-values/sin-cos-tan-serialize.html, https://wpt.fyi/results/css/css-values/round-mod-rem-serialize.html

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:dholbert, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Oliver Medhurst [:canadahonk]]

Two separate serialisation issues here:

• scale(calc(NaN), calc(NaN)) instead of scale(calc(NaN))
• Infinity is limited to a large value instead of using the calc constant

Comment 3

[Oliver Medhurst [:canadahonk]]

Splitting bug into two tiny bugs (see above).

Comment 4

[Tiaan Louw]

Attachment: Bug 1834361 - Deal with tan() asymptote angles r=#layout-reviewers

Now that inf and NaN values are supported, tan() with a right angle
value should return infinity.

tan(90) = infinity
tan(270) = -infinity

Also fixed a bug when serializing NaN values.

Comment 5

[Phabricator Automation]

Comment on attachment 9345535 [details]
Bug 1834361 - Deal with tan() asymptote angles r=#layout-reviewers

Revision D184465 was moved to bug 1850555. Setting attachment 9345535 [details] to obsolete.

Comment 6

[Oliver Medhurst [:canadahonk]]

This seems to have been fixed with another patch at some point recently - we pass all mod rem round serialize WPTs now! :)