1856158 - WPT failures in css/css-values/sin-cos-tan-serialize.html

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Thomas Wisniewski [:twisniewski]]

The tests being failed all seem to be of the form:

'scale(sin(180deg))' as a specified value should serialize as 'scale(calc(0))'.
'scale(cos(-270deg))' as a specified value should serialize as 'scale(calc(0))'.

Comment 1

[Daniel Holbert [:dholbert]]

Link to live test/results:
http://wpt.live/css/css-values/sin-cos-tan-serialize.html
https://wpt.fyi/results/css/css-values/sin-cos-tan-serialize.html

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1856158 - Simplify some numeric test code. r=dholbert,tlouw,#layout-reviewers

No behavior change, but this simplifies the code by using the individual
transform properties to test angles / numbers rather than the transform
property, and adds support for the approx argument to test_math_specified.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1856158 - Improve sin-cos-tan-serialize.html. r=dholbert,tlouw,#layout

Extend the test to also cover computed and used serialization, and also
make the test support approximated values for some values where even JS
doesn't give exact answers. E.g., Math.sin(Math.PI) is not 0, it's
1.2246467991473532e-16 here.

Depends on D193832

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6361485eb22
Simplify some numeric test code. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/6a7f5cf83216
Improve sin-cos-tan-serialize.html. r=dholbert

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b6361485eb22
https://hg.mozilla.org/mozilla-central/rev/6a7f5cf83216

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43253 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot